| Directory | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 208 (100.0%) | 2006 (100.0%) | 9.6 |
| / | 32 (15.4%) | 627 (31.3%) | 19.5 |
| Core/Grid/ | 4 (1.9%) | 235 (11.7%) | 58.7 |
| CCA/Components/Wasatch/transport/ | 4 (1.9%) | 197 (9.8%) | 49.2 |
| CCA/Components/Wasatch/Expressions/ | 17 (8.2%) | 145 (7.2%) | 8.5 |
| CCA/Components/Arches/ | 5 (2.4%) | 136 (6.8%) | 27.2 |
| StandAlone/tools/mpi_test/ | 5 (2.4%) | 130 (6.5%) | 26.0 |
| Core/Grid/Variables/ | 7 (3.4%) | 68 (3.4%) | 9.7 |
| Core/DataArchive/ | 2 (1.0%) | 58 (2.9%) | 29.0 |
| CCA/Components/Wasatch/ | 7 (3.4%) | 53 (2.6%) | 7.5 |
| CCA/Components/Wasatch/Expressions/BoundaryConditions/ | 8 (3.8%) | 42 (2.1%) | 5.2 |
| CCA/Components/LoadBalancers/ | 4 (1.9%) | 38 (1.9%) | 9.5 |
| R_Tester/helpers/ | 3 (1.4%) | 34 (1.7%) | 11.3 |
| CCA/Components/Schedulers/ | 1 (0.5%) | 32 (1.6%) | 32.0 |
| include/ | 2 (1.0%) | 30 (1.5%) | 15.0 |
| CCA/Components/DataArchiver/ | 4 (1.9%) | 30 (1.5%) | 7.5 |
| R_Tester/toplevel/ | 4 (1.9%) | 29 (1.4%) | 7.2 |
| build_scripts/ | 6 (2.9%) | 20 (1.0%) | 3.3 |
| CCA/Components/Regridder/ | 5 (2.4%) | 18 (0.9%) | 3.6 |
| CCA/Components/Arches/Radiation/ | 1 (0.5%) | 18 (0.9%) | 18.0 |
| Core/Geometry/ | 5 (2.4%) | 14 (0.7%) | 2.8 |
| CCA/Components/ProblemSpecification/ | 5 (2.4%) | 11 (0.5%) | 2.2 |
| Core/Datatypes/ | 47 (22.6%) | 7 (0.3%) | 0.1 |
| Core/ProblemSpec/ | 2 (1.0%) | 6 (0.3%) | 3.0 |
| Core/Util/ | 5 (2.4%) | 5 (0.2%) | 1.0 |
| CCA/Components/Arches/ChemMix/ | 2 (1.0%) | 5 (0.2%) | 2.5 |
| Core/Exceptions/ | 2 (1.0%) | 4 (0.2%) | 2.0 |
| Core/Math/ | 2 (1.0%) | 3 (0.1%) | 1.5 |
| Core/Grid/BoundaryConditions/ | 1 (0.5%) | 3 (0.1%) | 3.0 |
| StandAlone/ | 2 (1.0%) | 2 (0.1%) | 1.0 |
| CCA/Components/MPMArches/ | 1 (0.5%) | 2 (0.1%) | 2.0 |
| CCA/Components/Wasatch/Expressions/PostProcessing/ | 1 (0.5%) | 1 (0.0%) | 1.0 |
| CCA/Components/Wasatch/Expressions/MMS/ | 1 (0.5%) | 1 (0.0%) | 1.0 |
| CCA/Components/MPM/ConstitutiveModel/PlasticityModels/Validation/ | 4 (1.9%) | 1 (0.0%) | 0.2 |
| CCA/Components/ICE/ | 1 (0.5%) | 1 (0.0%) | 1.0 |
| StandAlone/tools/uda2nrrd/ | 2 (1.0%) | 0 (0.0%) | 0.0 |
| Core/Persistent/ | 2 (1.0%) | 0 (0.0%) | 0.0 |
| Core/IO/ | 2 (1.0%) | 0 (0.0%) | 0.0 |
D Wasatch/transport/EnthalpyTransportEquation.cpp
A + Wasatch/transport/EnthalpyTransportEquation.cc
- Renamed to match Uintah conventions and the name of the file in the sub.mk file...
I've seen this before, but still don't know how an error doesn't occur when
the suffix is ".cc" in the sub.mk file, but the actual file is a ".cpp".
M Wasatch/Expressions/BoundaryConditions/BoundaryConditions.cc
- Quited compiler warning by adding end-of-line to end of file.
- Fixed #include to specify entire path per Uintah conventions.
M Wasatch/transport/sub.mk
- Added newline at end of file, removed tabs.
197 lines of code changed in 6 files:
This fixes the problem Todd was seeing with very large domains.
M Core/Grid/Grid.cc
- Fix the problem with precision. Before, for large numbers, adding epsilon
did not change the number (due to not enough precision). See in-code
comments explaining this fix.
- Alphabetize the #includes.
M R_Tester/toplevel/startLocalTest
- Clean up (add white space) some of the error messages.
- Add the ability to point at a 'gold standard' TestData directory that is
in a different location then the current directory. To use this feature,
set the TEST_DATA environment variable with an absolute path to the
gold standard directory of choice.
M R_Tester/toplevel/generateGoldStandards.py
- Clean up output message.
M R_Tester/helpers/selectComponents.sh
- Print out a list of possible test components to make it easier for the user
to set the TEST_COMPONENTS environment variable.
101 lines of code changed in 7 files:
Number of cleanups and a fix to get Wasatch in Arches compiling.
M CCA/Components/Wasatch/CoordinateHelper.cc
M CCA/Components/Wasatch/TaskInterface.cc
- Comment out "oldVar" as it isn't used and this removes a compiler warning.
M CCA/Components/Wasatch/Expressions/BoundaryConditions/PressureBC.cc
- Add newline to end of file to remove compiler warning.
M CCA/Components/Wasatch/Expressions/BoundaryConditions/VardenMMSBCs.cc
- Don't define your own PI, just use the built in M_PI.
- #include paths should be absolute <>, not relative "".
- Add newline to end of file to remove compiler warning.
M CCA/Components/Wasatch/Expressions/BoundaryConditions/VardenMMSBCs.h
- Place multiple include guard at very top of file to speed file processing.
- #include paths should be absolute <>, not relative "".
- Remove tabs, add some white space for readability.
M CCA/Components/Arches/ExplicitSolver.cc
- Wasatch_in_Arches was not compiling for me... Had to fix use of
TaskInterface constructor - added in State variable. I assume this
is correct (at least it compiles). If someone from Warches could
verify, that would be great. I note James took a shot at fixing this
in the previous commit, but he only added the (non-existent?) variable
'state', to one of the places the state was needed.
- Indent #includes for readability.
M R_Tester/toplevel/startLocalTest
M R_Tester/helpers/runSusTests.py
- Allow the user to specify a different directory of Gold Standards to
test against. This is done using the environment variable
TEST_DATA. In other words, if you have built Gold Standards in
.../Uintah/opt/TestData, and you wish to test your debug build
against the opt generated gold standards, then, from your debug
directory, you do (assuming it is parallel to the opt dir):
setenv TEST_DATA ../opt/TestData
and then run "make runLocalRT" as normal.
M CCA/Components/Wasatch/TaskInterface.h
- Line up parameters for readability.
119 lines of code changed in 16 files:
Enable CUDA in Wasatch 3P build if Uintah is configured with CUDA.
M build_scripts/build_wasatch_3p.sh
- Handle newly passed in (from configure) with-cuda (yes/no) flag so
that SpatialOps will build with CUDA support as necessary.
M configure
M configure.ac
- Pass sci_required_cuda to build_wasatch_3p script.
M StandAlone/sub.mk
- Some OSes require the Wasatch 3P libs to be explicitly listed when linking sus.
15 lines of code changed in 5 files:
Add 'show_zlib' target for help in debugging when multiple zlibs are linked in. (Note, this shouldn't happen due to a fix in a previous commit, but just in case.)
0 lines of code changed in 2 files:
M CCA/Components/DataArchiver/DataArchiver.h
M CCA/Components/DataArchiver/DataArchiver.cc
M Core/Grid/Task.h
- Fix some indentation - add white space to make reading easier.
M CCA/Components/Arches/BoundaryCondition.cc
- Validate that all faces have been specified.
M Core/Grid/Grid.cc
- Fix for adding 'epsilon' to large numbers.
M Core/Grid/Variables/VarLabel.h
M Core/Grid/Variables/VarLabel.cc
- Remove 'using' syntax from .h file.
- Indent and use white space for easier reading.
- Use 'd_' for class variable: d_defaultCompressionMode
- Swat some evil 'endl's. :)
M Core/Math/Short27.h
M Core/Math/Matrix3.h
- Added some white space.
286 lines of code changed in 13 files:
M Point.h
M CompGeom.cc
Removed the Point's vector() operator that did a hard cast of the
Point into a Vector. While the Point and Vector have exactly the same
data members and this cast has (in theory) worked forever, at least on
newer Macs, casting one to the other does not work. It appears that this
was only used in one or two places, and they should just use the other
(constructor, etc) available functions for type safety reasons anyway.
Note, 'vector()' was also used in: src/CCA/Components/Wasatch/CoordHelper.cc
but James fixed this a commit or two ago. This error was what clued us
into the problem.
14 lines of code changed in 3 files:
Few cleanups based on icc compiler.
M configure
M configure.ac
- Need to clear out the list of test_libraries so that the next test only looks at those specified,
and not libs from a previous test.
M CCA/Components/LoadBalancers/ProfileDriver.h
M CCA/Components/LoadBalancers/ProfileDriver.cc
- Use d_ for class variables.
- Add some whitespace to make code readable.
- Line up variable names to make them much easier to read.
M CCA/Components/Arches/EfficiencyCalculator.h
M CCA/Components/Arches/NonlinearSolver.h
M Core/Grid/BoundaryConditions/BoundCondBase.h
- Returning a 'const' basic type does not make sense and by removing the 'const', we quiet the compiler warning.
- Line up the variables so they can be easily read.
- Remove unnecessary ; from the end of class member functions.
108 lines of code changed in 9 files:
New MKL lib list for newest Ember OS configuration
26 lines of code changed in 2 files:
See previous commit: A few more libs need the fix for mac linking of zlib.
0 lines of code changed in 6 files:
This commit will (hopefully) fix the Mac OSX regression tester.
M Makefile.in
- Don't run the verify_zlib if it is a static build.
M CCA/Components/ProblemSpecification/sub.mk
M Core/ProblemSpec/sub.mk
- On some Mac installs, the MPI library brings in a library load path
that has alternative system libraries in it. The most usual case is
with libz.dylib. If we don't add the MPI_LIBRARY line to this link
line, then these libs will link vs the system (usually /usr/lib/libz.dylib)
and thus we will have two different compression libraries linked
into the same executable... which will eventually cause a bad UDA to
be created.
M CCA/Components/ProblemSpecification/ProblemSpecReader.cc
- Add a better error message.
M CCA/Components/Regridder/TiledRegridder.cc
- Alphabetize the includes.
30 lines of code changed in 9 files:
Fix compilation problem... I can't locate a "SCIRun::Iterator"
type/class/etc... I assume this is supposed to be a
"Uintah::Iterator". It at least compiles successfully this way... If
the RT finds a problem, I will revert this fix.
7 lines of code changed in 1 file:
Apparently inside a makefile, the regular expression for a . has to be in [].
5 lines of code changed in 1 file:
Include list of duplicate libs in error message.
13 lines of code changed in 1 file:
libz.so is too specific... perhaps this way...
2 lines of code changed in 1 file:
Need to be more specific then 'libz'... trying 'libz.so'. Also, some shells do not like negative exit numbers so use 1.
4 lines of code changed in 1 file:
This is an update to try and catch the problem when multiple
(different) versions of zlib are linked into the same sus... This
mostly has occurred on the Mac, though it seems like it could also
happen under linux. Usually, sus, one of the Uintah .so's (or .dylibs
on a Mac), or a thirdparty lib that sus links against, somehow picks
up a different libz. Then, depending on which library, etc, calls for
compression, potentially a different version of libz is used during
the same execution. This occurs (only?) when saving UDAs with gzip
turned on, and unfortunatley is not detected until someone tries to
read the UDA back in... at which point the program crashes.
I have added two fixes that will hopefully help solve this problem.
1) Makefile.in
The Makefile will now attempt to verify that sus and the Uintah
libs only link vs a single libz. I have tested this on 'fake'
examples, but don't have a version of the code where the real problem
manifests, so am not 100% sure that it is correct.
2) Core/Grid/Variables/Variable.cc
The error manifests itself when the size of the compressed data is
read in and an invalid number is seen (usually something HUGE). The
committed fix is a hack as we can't be sure exactly how big the
invalid number will be, but this should be ok. Currently I am using
'1,000,000,000'. I don't believe a single variable for a single patch
would ever be this big. Note, the 'fix' only reports a potential
error when this occurs... though in theory if it is an error, then a
segfault will happen directly after the user notification.
46 lines of code changed in 2 files:
Display start/end time when running local RT.
8 lines of code changed in 1 file:
Removed extra ';' to quiet compiler warning.
1 lines of code changed in 1 file:
Need to use Uintah's mpi_defs include instead of hardcoding mpi.h.
0 lines of code changed in 2 files:
(25 more)