[root]/CCA/Components/ICE
Advection
(7 files, 2440 lines)
CustomBCs
(13 files, 3351 lines)
EOS
(25 files, 3580 lines)
PressureSolve
(0 files, 0 lines)
HypreStandAlone
(1 files, 91 lines)
SpecificHeatModel
(8 files, 547 lines)
TurbulenceModel
(9 files, 221 lines)
WallShearStressModel
(7 files, 111 lines)
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 112 (100.0%) | 1735 (100.0%) | 15.4 |
| harman | 91 (81.3%) | 1606 (92.6%) | 17.6 |
| jsutherland | 18 (16.1%) | 126 (7.3%) | 7.0 |
| tsaad | 2 (1.8%) | 2 (0.1%) | 1.0 |
| dav | 1 (0.9%) | 1 (0.1%) | 1.0 |
BC_bulletproofing()
- Thrown an exception if the pressure BC is specified more than once for a face.
0 lines of code changed in 2 files:
The user must specify the material when using inletVelocity profile BCs.
Only apply the BC to that matl.
Set the default value for addVariance = false.
0 lines of code changed in 2 files:
This one has been a long time coming.
Rip out the standard namespace opening that has been polluting header files throughout the framework. This crept into all sorts of places.
DO NOT open namespaces in header files. Ever.
126 lines of code changed in 18 files:
Now using consistent naming conventions for local and global variables.
46 lines of code changed in 3 files:
More work on adding variance to the inlet velocity profile.
7 lines of code changed in 5 files:
added printTask() and printSchedule() calls to each task
83 lines of code changed in 2 files:
Global:
- cleanup
- formatting
- added more scratch labels to aid in debugging (L_ij, M_ij, S_ij...etc)
These are controlled by #ifdef conditionals.
DynamicModel:
- fixed several multipatch bugs.
- added new method for setting boundary conditions. With some of the filtered
quantities the array size is bigger than the patch and you must set the BCs
in the ghost cells.
multi-patch impVortex == 1 patch impVortex
9 lines of code changed in 1 file:
Divided the global struct d_customBC_var_basket into two structs global & local.
Previously the var_basket was a "container" that was used to pass around both local and
global variables. In the threaded world that doesn't work. Therefore there's now
customBC_globalVars and customBC_localVars
The local struct contains all variables and structs that are local to the task/function.
The global struct contains only global variables.
This commit should not change the answers but the RT tests do not test all of the custom
boundary conditions.
185 lines of code changed in 7 files:
Fixed a threadsafety issue.
Moved a globally defined advection operator variable d_OFS to a locally defined struct
that it passed around.
24 lines of code changed in 2 files:
addExchangeToMomentumAndEnergy()
Fixed glaring performance issue:
- created a separate task for single material ICE problems. Reducing task execution time
from 8.4 -> 1.8 sec for Taylor Green.
113 lines of code changed in 2 files:
add_vel_FC_exchange:
performance improvements. Added if(numMatls ==1) section
Copy the StaticArray data into temporary arrays before accessing them. Static Arrays are
slow. Improved this code from 8.4 sec -> 3.6 sec for taylorGreen.
87 lines of code changed in 2 files:
- added initialization task to the Wall Shear Stress Models
- added sched_AddComputesRequires() so each model can schedule additional needed variables.
- Now using CCVariable<double> variable for the roughness instead of a double. This allows
for spatial variation. Still need to initialize it from either a file or geom_objects.
20 lines of code changed in 1 file:
- The wallShearStressModel (WSS) is now applied to all ICE materials if the viscosity > 0;
- added hooks in viscousShearStress() task for calling the WSS model.
- instrumented code
** It's running but needs further testing **
27 lines of code changed in 6 files:
save the turbulent viscosity to the DW for diagnostics.
8 lines of code changed in 1 file:
- removed debugging output
- cleaned up formatting on DebugStreams output
- taking into account possibility of a negative grid origin.
15 lines of code changed in 2 files:
Added equations to the inner loops. Cleaned out dead wood from copy & paste.
Next: verification on single and multi-patches.
Usage:
<Grid>
<BoundaryConditions>
<inletVelocity type="powerLawProfile">
<verticalDirection> 1 </verticalDirection>
<exponent> 1 </exponent>
</inletVelocity>
OR
<inletVelocity type="logWindProfile">
<verticalDirection> 1 </verticalDirection>
<roughness> 0.01 </roughness>
</inletVelocity>
< snip >
<Face side = "x-">
<BCType id = "1" label = "Velocity" var = "powerLawProfile">
<value> [1.,0,1.] </value>
</BCType>
OR
<BCType id = "1" label = "Velocity" var = "logWindProfile">
<value> [1.,0,1.] </value>
</BCType>
</Face>
snip
</Boundary Conditions>
4 lines of code changed in 2 files:
BC cells are being touched, but the equations still need to be filled in.
22 lines of code changed in 3 files:
Initial commit for power law and log law inlet velocity profiles. This is just a
skeleton and needs to be filled in.
2 lines of code changed in 1 file:
accumulateMomentumSourceSinks()
Put the divergence of the viscous forces computation into a separate task.
*This should not change the answers.
214 lines of code changed in 4 files:
accumulateMomentumSourceSinks()
- shear stress components can now be saved to an uda.
- cleaned house.
* This should not change the answers.
118 lines of code changed in 2 files:
Additional warning if an uninitialized variable has been found.
3 lines of code changed in 1 file:
M configure.ac
M configure
- Fix checking for exceptions (this is necessary when an LDFLAGS var (or
CFLAGS) is hard coded on the configure line). (Most of our configure
compilation commands add these automatically, but for some reason we
are manually compiling this test, so need to add these variables our
self.)
- Take care of the case where the user wants to use mpif77 (instead
of just the name of the actual compiler). Do this by assuming
mpif77 is gfortran... print out a warning message to this effect.
(Note, if this is not the case, then much more complicated (assuming
it is even possible) logic would be needed to determine the actual
compiler.)
M CCA/Components/MPMArches/sub.mk
- In some builds (when Wasatch is turned on), MPMArches is
required to link against boost... so need to add $(BOOST_LIBRARY) to
the LIBS line.
M CCA/Components/ICE/ICE.cc
- Indentation.
M Core/Exceptions/AssertionFailed.cc
- If exceptions are broken, then need to include iostream for cout.
1 lines of code changed in 1 file:
Refactored how the shear stresses are computed. At the edge of the computational domain you need to
use dx/2 so the normal velocity gradients are computed correctly. This will change the results.
128 lines of code changed in 4 files:
Removed the last remnants of the "addMaterial" code. It hasn't been used for years.
1 lines of code changed in 2 files:
Initialize the wall shear stress model
1 lines of code changed in 1 file:
removed scheduleInitializeAddedMaterial()
- It hasn't been used in 5+ years.
0 lines of code changed in 2 files:
Now creating a wallShearStressModel for each ice matl.
-pruned #includes
40 lines of code changed in 3 files:
removed all calls to printData()
35 lines of code changed in 6 files:
fix typo in two ICE warnings.
2 lines of code changed in 2 files:
Cosmetics, 2 space indentation, alignment....etc.
226 lines of code changed in 2 files:
Added framework for shear stress models at the edge of the computational domain.
Everything is empty and it's not tied into ICE yet
1 lines of code changed in 2 files:
Moved the turbulence models into a separate directory.
You should run "make reallyclean" before you recompile
7 lines of code changed in 11 files:
replaced divisions by multiplications for speed.
136 lines of code changed in 1 file:
Added bulletproofing to AMRICE.
Input files:
Changed the regridder type from BNR or Hierarchical to the Tiled algorithm.
The tiled regridder is faster, scales better and the other regridders create patches that
are partially filled with old data. The refine() task was designed to work
over an entire patch and don't want to overwrite the old data, thus only use the tiled regridder.
33 lines of code changed in 2 files:
- Added scheduleRefine() to the ModelInterface
- Adde a call to scheduleRefine in AMRICE
- Defined the refine task for the DDT1 burn model
10 lines of code changed in 1 file:
Removed some old rotted out plumbing:
- scheduleCheckNeedAddMaterial()
- activateModel()
This idea died and blew away years ago.
* should not change answers
0 lines of code changed in 2 files:
Passing restart_problem_spec into the OnTheFly Analysis modules.
1stLawThermo: now parsing the restart_problem_spec on a
restart for the MPM material properties
1 lines of code changed in 1 file: