Lines of Code
[root]/CCA/Components/LoadBalancers
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 17 (100.0%) | 76 (100.0%) | 4.4 |
| dav | 4 (23.5%) | 38 (50.0%) | 9.5 |
| jsutherland | 10 (58.8%) | 25 (32.9%) | 2.5 |
| jthornoc | 3 (17.6%) | 13 (17.1%) | 4.3 |
This one has been a long time coming.
Rip out the standard namespace opening that has been polluting header files throughout the framework. This crept into all sorts of places.
DO NOT open namespaces in header files. Ever.
25 lines of code changed in 10 files:
Few cleanups based on icc compiler.
M configure
M configure.ac
- Need to clear out the list of test_libraries so that the next test only looks at those specified,
and not libs from a previous test.
M CCA/Components/LoadBalancers/ProfileDriver.h
M CCA/Components/LoadBalancers/ProfileDriver.cc
- Use d_ for class variables.
- Add some whitespace to make code readable.
- Line up variable names to make them much easier to read.
M CCA/Components/Arches/EfficiencyCalculator.h
M CCA/Components/Arches/NonlinearSolver.h
M Core/Grid/BoundaryConditions/BoundCondBase.h
- Returning a 'const' basic type does not make sense and by removing the 'const', we quiet the compiler warning.
- Line up the variables so they can be easily read.
- Remove unnecessary ; from the end of class member functions.
38 lines of code changed in 4 files:
[Dav de St. Germain commit via Jeremy's account/git:]
The following commit fixes a problem with the way Fortran files are
added into the Uintah framework. As you may know, the perl script
'fspec.pl.in' reads in a fortran spec file (eg: bcuvel.fspec) and
converts it into a .h file (bcuvel_fort.h), converting things such as
IntVectors into arrays of integers (etc) in order to pass Uintah
variables back and forth with the fortran code. To use the fortran
code, the generated .h file is included into a Uintah .cc file and the
function is called. Compilation problems arose when the fortran .h
file was included before a blanket "using namespace Uintah" appeared.
This was because the generated fortran .h file did not use the correct
"Uintah::" namespace qualifiers, and instead relied on some other file
to open up the namespace. I have fixed the script to now use
"Uintah::" correctly. Additionally, I have removed a lot of namespace
polluting "using namespaces" from around the code.
CCA/Components/Arches/Arches.cc
CCA/Components/Arches/CompDynamicProcedure.h
CCA/Components/Arches/IncDynamicProcedure.h
- Clean up due to "using namespace std" being removed from included .h file.
CCA/Components/Arches/Radiation/DORadiationModel.cc
CCA/Components/Arches/Source.cc
- Clean up due to "using namespace std" being removed from included .h file.
- Some better indentation.
- Put all _fort.h includes next to each other.
CCA/Components/Arches/water/watertp.h
CCA/Components/Models/FluidsBased/ArchesTable.cc
CCA/Ports/SFC.h
Core/Exceptions/InvalidCompressionMode.h
Core/Exceptions/InvalidValue.h
Core/Exceptions/ProblemSetupException.h
Core/Exceptions/UintahPetscError.h
Core/IO/SpecializedRunLengthEncoder.h
Core/Math/Short27.h
- Remove polluting "using namespace" from .h file.
CCA/Components/LoadBalancers/CostModelForecaster.cc
CCA/Components/LoadBalancers/CostModelForecaster.h
- Indentation, spacing.
- Use 'd_' for a class variable to be consistent with rest of class.
Core/Grid/Variables/Variable.cc
StandAlone/Benchmarks/SimpleMath.cc
StandAlone/tools/pfs/rawToUniqueGrains.cc
- Move "using namespace" into the .cc file as it was removed from the .h files.
tools/fspec.pl.in
- Make the perl script include the "Uintah::" for Uintah
variables so that a "using namespace Uintah" statement is not
required.
13 lines of code changed in 3 files: