Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 46 (100.0%) | 36 (100.0%) | 0.7 |
| jthornoc | 4 (8.7%) | 26 (72.2%) | 6.5 |
| jsutherland | 4 (8.7%) | 6 (16.7%) | 1.5 |
| dav | 2 (4.3%) | 4 (11.1%) | 2.0 |
| jas | 36 (78.3%) | 0 (0.0%) | 0.0 |
Reverting the use of Boost to perform file and directory copies for restarting.
0 lines of code changed in 36 files:
This one has been a long time coming.
Rip out the standard namespace opening that has been polluting header files throughout the framework. This crept into all sorts of places.
DO NOT open namespaces in header files. Ever.
6 lines of code changed in 4 files:
[Dav de St. Germain commit via Jeremy's account/git:]
The following commit fixes a problem with the way Fortran files are
added into the Uintah framework. As you may know, the perl script
'fspec.pl.in' reads in a fortran spec file (eg: bcuvel.fspec) and
converts it into a .h file (bcuvel_fort.h), converting things such as
IntVectors into arrays of integers (etc) in order to pass Uintah
variables back and forth with the fortran code. To use the fortran
code, the generated .h file is included into a Uintah .cc file and the
function is called. Compilation problems arose when the fortran .h
file was included before a blanket "using namespace Uintah" appeared.
This was because the generated fortran .h file did not use the correct
"Uintah::" namespace qualifiers, and instead relied on some other file
to open up the namespace. I have fixed the script to now use
"Uintah::" correctly. Additionally, I have removed a lot of namespace
polluting "using namespaces" from around the code.
CCA/Components/Arches/Arches.cc
CCA/Components/Arches/CompDynamicProcedure.h
CCA/Components/Arches/IncDynamicProcedure.h
- Clean up due to "using namespace std" being removed from included .h file.
CCA/Components/Arches/Radiation/DORadiationModel.cc
CCA/Components/Arches/Source.cc
- Clean up due to "using namespace std" being removed from included .h file.
- Some better indentation.
- Put all _fort.h includes next to each other.
CCA/Components/Arches/water/watertp.h
CCA/Components/Models/FluidsBased/ArchesTable.cc
CCA/Ports/SFC.h
Core/Exceptions/InvalidCompressionMode.h
Core/Exceptions/InvalidValue.h
Core/Exceptions/ProblemSetupException.h
Core/Exceptions/UintahPetscError.h
Core/IO/SpecializedRunLengthEncoder.h
Core/Math/Short27.h
- Remove polluting "using namespace" from .h file.
CCA/Components/LoadBalancers/CostModelForecaster.cc
CCA/Components/LoadBalancers/CostModelForecaster.h
- Indentation, spacing.
- Use 'd_' for a class variable to be consistent with rest of class.
Core/Grid/Variables/Variable.cc
StandAlone/Benchmarks/SimpleMath.cc
StandAlone/tools/pfs/rawToUniqueGrains.cc
- Move "using namespace" into the .cc file as it was removed from the .h files.
tools/fspec.pl.in
- Make the perl script include the "Uintah::" for Uintah
variables so that a "using namespace Uintah" statement is not
required.
26 lines of code changed in 4 files:
M configure.ac
M configure
- Fix checking for exceptions (this is necessary when an LDFLAGS var (or
CFLAGS) is hard coded on the configure line). (Most of our configure
compilation commands add these automatically, but for some reason we
are manually compiling this test, so need to add these variables our
self.)
- Take care of the case where the user wants to use mpif77 (instead
of just the name of the actual compiler). Do this by assuming
mpif77 is gfortran... print out a warning message to this effect.
(Note, if this is not the case, then much more complicated (assuming
it is even possible) logic would be needed to determine the actual
compiler.)
M CCA/Components/MPMArches/sub.mk
- In some builds (when Wasatch is turned on), MPMArches is
required to link against boost... so need to add $(BOOST_LIBRARY) to
the LIBS line.
M CCA/Components/ICE/ICE.cc
- Indentation.
M Core/Exceptions/AssertionFailed.cc
- If exceptions are broken, then need to include iostream for cout.
4 lines of code changed in 2 files: