Lines of Code
[root]/Core/Grid/BoundaryConditions
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 93 (100.0%) | 744 (100.0%) | 8.0 |
| tsaad | 51 (54.8%) | 671 (90.2%) | 13.1 |
| jsutherland | 39 (41.9%) | 58 (7.8%) | 1.4 |
| harman | 1 (1.1%) | 10 (1.3%) | 10.0 |
| dav | 1 (1.1%) | 3 (0.4%) | 3.0 |
| jthornoc | 1 (1.1%) | 2 (0.3%) | 2.0 |
remove a warning when parsing boundary conditions. this places the burden of bulletproofing on the component developers.
0 lines of code changed in 2 files:
Fix yet another bug related to the silly cast from Point to Vector. This is likely a costly fix since I opted for creating a vector instead of a cast by adding a sister function called toVector() opposed to asVector(), which does the cast. This will hopefully fix other issues that we were having when using unions/differences on boundaries...
0 lines of code changed in 2 files:
This one has been a long time coming.
Rip out the standard namespace opening that has been polluting header files throughout the framework. This crept into all sorts of places.
DO NOT open namespaces in header files. Ever.
58 lines of code changed in 39 files:
Few cleanups based on icc compiler.
M configure
M configure.ac
- Need to clear out the list of test_libraries so that the next test only looks at those specified,
and not libs from a previous test.
M CCA/Components/LoadBalancers/ProfileDriver.h
M CCA/Components/LoadBalancers/ProfileDriver.cc
- Use d_ for class variables.
- Add some whitespace to make code readable.
- Line up variable names to make them much easier to read.
M CCA/Components/Arches/EfficiencyCalculator.h
M CCA/Components/Arches/NonlinearSolver.h
M Core/Grid/BoundaryConditions/BoundCondBase.h
- Returning a 'const' basic type does not make sense and by removing the 'const', we quiet the compiler warning.
- Line up the variables so they can be easily read.
- Remove unnecessary ; from the end of class member functions.
3 lines of code changed in 1 file:
do not report warning when no values are specified for symmetry and zeroNeumann BCs. To the best of my knowledge, those two bcs are specific to ICE.
3 lines of code changed in 1 file:
rip out an obsolete function that was replace with function_NEW(). Enforce the type of boundary on difference and union boundaries.
0 lines of code changed in 4 files:
Added a new line to the boundary warning.
Changed mpmpipe_test to use new BCs. **This will break RT**
2 lines of code changed in 1 file:
use proc0cout for a warning that I recently put in BoundCondFactory
2 lines of code changed in 1 file:
1. Add a python script that converts ups <value> spec to value attribute
2. Add a <DefaultMaterial> option in the <BoundaryConditions> specification. This will allow us to get rid of the material id attribute in BCType for components that have a single material only. The behavior here is fully backwards compatible. If neither DefaulMaterial nor id are specified, then an exception is thrown.
3. Add a python script that will remove the material id and add a <DefaultMaterial> node to your ups file.
Let me know if you need help using these scripts.
43 lines of code changed in 3 files:
Allow users to specify BC values via a value attribute instead of an xml child. This will help reduce the number of lines in the BC specification by up to 66%. Based on conversation with Todd and Jeremy, this commit is fully backward compatible to smooth the transition. You don't have to change any of your input files at the moment. if you want to adopt the new specification, see my next commit for examples. If you are a user, please consult with your component developer for possible implications of using this new interface. A script is being developed to help you convert your input files into using the new format.
40 lines of code changed in 1 file:
Add outflow and atmosphere boundary conditions. Improve the logic when applying user-friendly boundary types. Move pressure-related bcs (matrix coefs, pressure) to the BCHelper. This commit could potentially break two tests with diffs @ machine precision.
1 lines of code changed in 1 file:
Add more functionality to the BCHelper class. This commit paves the way for logical reasoning on boundary types (Wall, outlet...): one can check the validity of user-specified BCs, or automate the application of BCs for certain equations. This greatly simplifies the input file and takes a removes most of the guess-work that a user may be faced with. The neat thing is that we also allow a USER boundary type for freedom in applying any desired BC.
14 lines of code changed in 3 files:
1. Fix a typo in the function faceTypeToString that I added last week.
2. Allow one to access a boundary face iterator when no boundary conditions have been specified at that boundary face.
15 lines of code changed in 1 file:
Further interface updates to the new BC treatment in Wasatch. Today's version is based on Boundaries instead of Boundary-Conditions. As a result, a new Boundary Type was added to the Face spec in Uintah. This allows us to reason on boundary types and select appropriate boundary conditions.
21 lines of code changed in 3 files:
This is a major (and beautiful) commit for Wasatch. It entails a complete refactoring of the boundary conditions for ease of use, efficiency (?), and the new Nebo syntax for handling masks (e.g. BC iterators) in general. Some of the things were changed in this commit include:
1. ripping out the functor_name from the uintah boundary condition suite. those are now set in the <value> tag of the boundary condition.
2. converting all boundary conditions to use ijk indexing instead of flat. Nebo will eventually do its magic behind the scenes.
3. A new BCHelper class that manages all boundary conditions, their iterators, names etc...
4. A pre-processing step on input files to guarantee that <Face> specification has a unique name. This pre-processing step will automatically rename duplicates or put unique names if the user has not specified any.
A key assumption for this new approach is centered around the <Face> specification as being a single boundary condition - that is, you MUST specify ALL relevant boundary conditions within the same <Face> spec.
5 lines of code changed in 3 files:
Second attempt at removing the auxiliary boundary condition. This time, I put in the fixes - to the best of my knowledge - for the other components. The majority of the problems were fixed by a simple fix to the BCUtils.h getIteratorBCValueBCKind function. The other change was in MPMBoundCond.cc which I hope the MPM developers will agree with. Local regression passed on all components that provide localtests. I leave it to the buildbot and the nightly RT to check for the rest. 'If it ain't broke, then it probably violates the second law' (Tony Saad).
27 lines of code changed in 4 files:
1. Add a method to BCData to access the boundary conditions (BoundCondBase) vector associated with a given BCData class.
2. Add an enum and its access method to BoundCondBase that allows us to infer the data type of the value set by a boundary condition (BoundCondBase). This will make infering the data for BoundCond much more robust when doing the dynamic_cast. Currently, components infer the type of the BoundCond by doing logical deductions on the variable name, which is prone to errors. This new method will allow you to deduce data type based on the input specification.
56 lines of code changed in 5 files:
No comment.
0 lines of code changed in 1 file:
1. Fix a subtle bug in Wasatch that showed up when trying to remove the Auxiliary variable yesterday.
2. Add a new function to BCUtils that allows one to access the boundary value specified for a given variable.
324 lines of code changed in 2 files:
revert even more code to stop the segfaults.
106 lines of code changed in 3 files:
rip out the obsolete Auxiliary boundary condition.
0 lines of code changed in 3 files:
change BoundCondBase::getBCType__NEW to getBCType. I don't know which of the following is better though, appending __OLD or __NEW...
12 lines of code changed in 6 files:
make the print() method of BCDataArray const.
2 lines of code changed in 2 files:
BoundCondFactory.cc
- create()
The boundary condition is considered an integer if the attribute
'type = "int"' is included. If the attribute isn't there it will default
to a double.
Ray.cc/h
The user can now specify boundary conditions for the cellType. Use:
<BCType id = "0" label = "cellType" var = "Dirichlet" type = "int">
<value> 8 </value> ^^^^^^^^^^^^
</BCType>
10 lines of code changed in 1 file: