/trunk/src Developers: charlesreid

Login name:
charlesreid
Total Commits:
433 (2.3%)
Lines of Code:
15777 (6.9%)
Most Recent Commit:
2009-12-12 19:14

Activity by Clock Time

Activity by Hour of Day for charlesreid

Activity by Day of Week for charlesreid

Activity in Directories

Directory Changes Lines of Code Lines per Change
Totals 433 (100.0%) 15777 (100.0%) 36.4
CCA/Components/Arches/CoalModels/ 139 (32.1%) 6322 (40.1%) 45.4
CCA/Components/Arches/ 105 (24.2%) 4595 (29.1%) 43.7
CCA/Components/SpatialOps/ 38 (8.8%) 1355 (8.6%) 35.6
CCA/Components/Arches/TransportEqns/ 38 (8.8%) 1149 (7.3%) 30.2
CCA/Components/SpatialOps/CoalModels/ 55 (12.7%) 830 (5.3%) 15.0
CCA/Components/SpatialOps/matlab/ 15 (3.5%) 800 (5.1%) 53.3
Packages/Uintah/CCA/Components/Arches/ 11 (2.5%) 595 (3.8%) 54.0
CCA/Components/SpatialOps/TransportEqns/ 13 (3.0%) 51 (0.3%) 3.9
CCA/Components/Arches/SourceTerms/ 9 (2.1%) 50 (0.3%) 5.5
Core/Math/ 2 (0.5%) 17 (0.1%) 8.5
Core/Datatypes/ 3 (0.7%) 9 (0.1%) 3.0
StandAlone/ 1 (0.2%) 3 (0.0%) 3.0
Packages/Uintah/CCA/Components/Arches/TabProps/ 2 (0.5%) 1 (0.0%) 0.5
CCA/Components/ 2 (0.5%) 0 (0.0%) 0.0

Activity of charlesreid

Most Recent Commits

charlesreid 2009-12-12 19:14 Rev.: 45195

Memory fix

0 lines of code changed in 2 files:

  • CCA/Components/Arches: Filter.cc (new)
charlesreid 2009-12-07 00:57 Rev.: 45170

Changing delete's to delete[]'s

4 lines of code changed in 1 file:

  • CCA/Components/Arches: DQMOM.cc (+4 -4)
charlesreid 2009-12-05 22:42 Rev.: 45169

Fixing one more compiler warning

1 lines of code changed in 1 file:

  • CCA/Components/Arches/CoalModels: SimpleHeatTransfer.cc (+1)
charlesreid 2009-12-04 16:01 Rev.: 45164

Fixing compiler warning

18 lines of code changed in 1 file:

  • CCA/Components/Arches/CoalModels: SimpleHeatTransfer.cc (+18 -11)
charlesreid 2009-12-01 20:46 Rev.: 45144

Removing debug print statement

0 lines of code changed in 1 file:

  • CCA/Components/Arches: DQMOM.cc (-2)
charlesreid 2009-12-01 20:41 Rev.: 45143

M CCA/Components/Arches/sub.mk
Fixing duplicate line added in a previous commit

M CCA/Components/Arches/DQMOM.h
M CCA/Components/Arches/DQMOM.cc
Adding a <calcConditionNumber> tag - this will be useful and necessary if we want condition numbers but the solver isn't doing an SVD to solve AX=B
Clarifying names of solvers:
- "Lapack-invert" uses a Lapack decomposition and inversion (dgetrf and dgetri)
- "Lapack-svd" uses a Lapack singular value decomposition to solve AX=B (eliminated the "SVD" solver type)
- "LU" uses Crout's Method with partial pivoting
Fixing up the DEBUG_MATRICES blocks
Adding a maximum condition number solver constraint

M StandAlone/inputs/UPS_SPEC/arches_spec.xml
Updating tags corresponding to clarified linear solver names

M StandAlone/inputs/ARCHES/DQMOM_regression/dqmom-scalar_test2c.ups
This test was redundant, but it's now testing the "Lapack-invert" solver

M StandAlone/inputs/ARCHES/DQMOM_regression/dqmom-scalar_test3.ups
M StandAlone/inputs/ARCHES/DQMOM_regression/test_descriptions.lyx
The "SVD" solver is now the "Lapack-svd" solver; test 2c is now testing the "Lapack-invert" solver

255 lines of code changed in 5 files:

  • CCA/Components/Arches: DQMOM.cc (+249 -138), DQMOM.h (+6 -1), sub.mk (-1)
charlesreid 2009-12-01 01:28 Rev.: 45136

Accidentally uncommented a directive in my last commit

0 lines of code changed in 2 files:

  • CCA/Components/Arches: Directives.h (changed)
charlesreid 2009-12-01 01:27 Rev.: 45135

M Directives.h
Making comments more user-friendly

M CoalModels/HeatTransfer.cc
Fixing a problem with unfound tags

13 lines of code changed in 3 files:

  • CCA/Components/Arches: Directives.h (+6 -16)
  • CCA/Components/Arches/CoalModels: HeatTransfer.cc (+7 -3)
charlesreid 2009-11-30 19:22 Rev.: 45130

M Arches/DQMOM.cc
Fixing bug in debug print statements

M Arches/Directives.h
Adding debug print statement compiler directive

12 lines of code changed in 2 files:

  • CCA/Components/Arches: DQMOM.cc (+3 -2), Directives.h (+9)
charlesreid 2009-11-28 21:07 Rev.: 45123

Supressing error message printing

2 lines of code changed in 1 file:

  • CCA/Components/Arches: DQMOM.cc (+2 -2)
charlesreid 2009-11-24 16:43 Rev.: 45119

Fixing a memory leak

M CCA/Components/Arches/DQMOM.cc
Cleaning up, deleting some variables that weren't deleted before

M Core/Math/sci_lapack.cc
Changing some "delete"s to "delete[]"s

M Core/Datatypes/DenseMatrix.cc
Instead of always returning true, now returning INFO (Lapack variable indicating the solution status)

31 lines of code changed in 4 files:

  • CCA/Components/Arches: DQMOM.cc (+13 -26)
  • Core/Datatypes: DenseMatrix.cc (+1 -2)
  • Core/Math: sci_lapack.cc (new)
charlesreid 2009-11-23 14:53 Rev.: 45115

Making a tag not required and adding an explanation of it

94 lines of code changed in 1 file:

  • CCA/Components/Arches/CoalModels: CoalModelFactory.cc (+94 -93)
charlesreid 2009-11-22 18:54 Rev.: 45111

M CCA/Components/Arches/CoalModels/SimpleHeatTransfer.cc
Fixing compiler warning

M CCA/Components/Arches/TransportEqns/EqnBase.h
Minor edits

M CCA/Components/Arches/TransportEqns/DQMOMEqn.cc
Bulletproofing problemSetup()

M CCA/Components/Arches/DQMOM.cc
Fixing bugs in moment calculation
Rearranging get() calls so they aren't happening at each cell

92 lines of code changed in 4 files:

  • CCA/Components/Arches: DQMOM.cc (+67 -25)
  • CCA/Components/Arches/CoalModels: SimpleHeatTransfer.cc (-2)
  • CCA/Components/Arches/TransportEqns: DQMOMEqn.cc (+23 -7), EqnBase.h (+2 -2)
charlesreid 2009-11-21 01:17 Rev.: 45108

M CCA/Components/Arches/CoalModels/BadHawkDevol.h
M CCA/Components/Arches/CoalModels/ModelBase.h
M CCA/Components/Arches/CoalModels/ConstantModel.h
M CCA/Components/Arches/CoalModels/Devolatilization.h
M CCA/Components/Arches/CoalModels/HeatTransfer.cc
M CCA/Components/Arches/CoalModels/HeatTransfer.h
M CCA/Components/Arches/LU.h
Minor edits

M CCA/Components/Arches/DQMOM.cc
Removing some timings

M CCA/Components/Arches/CoalModels/DragModel.h
M CCA/Components/Arches/CoalModels/DragModel.cc
Removing conversion functions for velocity (Cartesian <--> spherical) and calling them statically from PartVel class

M CCA/Components/Arches/CoalModels/PartVel.h
Making velocity conversion functions (Cartesian <--> spherical) public and static

M CCA/Components/Arches/CoalModels/SimpleHeatTransfer.cc
M CCA/Components/Arches/CoalModels/SimpleHeatTransfer.h
Using vector length()'s instead of the Cartesian <--> spherical methods
Adding verification procedure

M CCA/Components/Arches/CoalModels/KobayashiSarofimDevol.cc
M CCA/Components/Arches/CoalModels/KobayashiSarofimDevol.h
Adding verification procedure
Adding two sets of constants, one from Kobayashi and one from Ubhayakar
Fixing Y1_ value

M CCA/Components/Arches/CoalModels/CoalModelFactory.cc
M CCA/Components/Arches/CoalModels/CoalModelFactory.h
Adding problemSetup method (to be used in future coupled physics calculations)
Adding method to set ArchesLabel (to be used in future coupled physics calculations)
Building models when they are first added to the build map, as opposed to when they are requested for the first time

M CCA/Components/Arches/Arches.cc
Adding call to set ArchesLabel in CoalModelFactory (to be used in future coupled physics calculations)

M CCA/Components/Arches/TransportEqns/ScalarEqn.h
M CCA/Components/Arches/TransportEqns/ScalarEqn.cc
Adding directives header file

M CCA/Components/Arches/Directives.h
Adding new verification directives

A StandAlone/inputs/ARCHES/Verification/verify_devol_heatxfer_models.ups
Adding input files for running new model verification procedures (it also has working moments for 3 internal coordinates and 4 environments)

M StandAlone/inputs/UPS_SPEC/arches_spec.xml
Updating UPS spec

1153 lines of code changed in 33 files:

  • CCA/Components/Arches: Arches.cc (+8 -5), DQMOM.cc (+21 -29), Directives.h (+14 -4), LU.h (-3)
  • CCA/Components/Arches/CoalModels: BadHawkDevol.h (new), CoalModelFactory.cc (+252 -24), CoalModelFactory.h (+80 -9), ConstantModel.h (new), Devolatilization.h (+9 -7), DragModel.cc (+9 -9), DragModel.h (+28 -69), HeatTransfer.cc (+6 -5), HeatTransfer.h (+11 -55), KobayashiSarofimDevol.cc (+203 -102), KobayashiSarofimDevol.h (new), ModelBase.h (new), PartVel.h (new), SimpleHeatTransfer.cc (+394 -180), SimpleHeatTransfer.h (+24 -19)
  • CCA/Components/Arches/TransportEqns: ScalarEqn.cc (-1), ScalarEqn.h (+1 -3)
charlesreid 2009-11-18 22:52 Rev.: 45094

Moving the "get" calls so that they only happen once, and not at every cell. This significantly reduces the time spent on these calls.

77 lines of code changed in 2 files:

  • CCA/Components/Arches: DQMOM.cc (+63 -25), DQMOM.h (+14 -2)
charlesreid 2009-11-17 18:17 Rev.: 45073

Moving compiler directives for verification into a new header file, Directives.h

33 lines of code changed in 8 files:

  • CCA/Components/Arches: BoundaryCond_new.h (+1 -4), DQMOM.cc (+1 -1), DQMOM.h (+2 -16), Directives.h (+25), ExplicitTimeInt.h (+1 -3)
  • CCA/Components/Arches/TransportEqns: DQMOMEqn.h (+1 -6), Discretization_new.h (+1 -4), EqnBase.h (+1 -3)
charlesreid 2009-11-17 18:14 Rev.: 45072

Adding DenseMatrix (which utilizes Lapack) to DQMOM class

1087 lines of code changed in 8 files:

  • CCA/Components/Arches: DQMOM.cc (+1031 -260), DQMOM.h (+39 -19), LU.cc (new), sub.mk (+1)
  • Core/Datatypes: SparseRowMatrix.cc (new)
  • StandAlone: sus.cc (+3)
charlesreid 2009-11-10 17:42 Rev.: 45055

Fixing compiler warning

1 lines of code changed in 1 file:

  • CCA/Components/Arches/TransportEqns: DQMOMEqn.cc (+1 -1)
charlesreid 2009-11-10 02:03 Rev.: 45052

Transferring contrl of the model evaluations to the CoalModelFactory.
This will not change answers (no, really, this time I made sure - I fixed the problem with gas-phase source terms).

This transfer will make verification of the model terms easier.
It will also pave the way for implementation of an iterative, coupled particle calculation.

642 lines of code changed in 26 files:

  • CCA/Components/Arches: Arches.cc (+8 -4), DQMOM.cc (+3), ExplicitSolver.cc (+5 -4)
  • CCA/Components/Arches/CoalModels: BadHawkDevol.cc (-17), CoalModelFactory.cc (+14), CoalModelFactory.h (+32 -20), ConstantModel.cc (+69 -15), ConstantModel.h (+28 -13), Devolatilization.cc (+101 -18), Devolatilization.h (+33 -33), DragModel.cc (+1 -1), DragModel.h (+4 -1), HeatTransfer.cc (+53 -616), HeatTransfer.h (+47 -83), KobayashiSarofimDevol.cc (+35 -158), KobayashiSarofimDevol.h (+38 -47), ModelBase.cc (+20 -11), ModelBase.h (+48 -33), PartVel.cc (+10 -9), SimpleHeatTransfer.cc (+19 -101), SimpleHeatTransfer.h (+61 -32), sub.mk (+2)
  • CCA/Components/Arches/TransportEqns: DQMOMEqn.cc (+11 -5)
charlesreid 2009-11-08 21:30 Rev.: 45048

Fixing compiler warning

1 lines of code changed in 1 file:

  • CCA/Components/Arches: DQMOM.cc (+1 -1)

(93 more)

Generated by StatSVN 0.4.0