Lines of Code
[root]/CCA/Components/SpatialOps/CoalModels
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 109 (100.0%) | 1794 (100.0%) | 16.4 |
| jthornoc | 45 (41.3%) | 888 (49.5%) | 19.7 |
| charlesreid | 55 (50.5%) | 830 (46.3%) | 15.0 |
| dav | 9 (8.3%) | 76 (4.2%) | 8.4 |
Gave SpatialOps a lobotomy. Now linking in all factories, models, sources, and equations from the Arches code base rather than maintaining two copies. This should resolve any naming conflicts.
0 lines of code changed in 15 files:
Forgot to do "svn move"
0 lines of code changed in 4 files:
Fixing naming conflict with ModelFactory by moving this model factory to SpatialOpsCoalModelFactory
5 lines of code changed in 10 files:
1) Fixed bugs in Ax=b solver.
2) Fixed sign error in DQMOMEqn.cc
3) Fixed src*vol in DQMOMEqn.cc
1 lines of code changed in 2 files:
M CoalModels/PartVel.cc
M CoalModels/PartVel.h
- Fixed some bugs in the Particle velocity model. The model is adding to the magnitude of velocity...do we want to try adding to the components?
M TransportEqns/ScalarEqn.h
- Passing the timesubStep into the task properly.
M TransportEqns/EqnBase.cc
M TransportEqns/EqnBase.h
- Added a mechanism for storing initial conditions (still need to allow for reading in from the input file).
- Added an "old" transport varLabel for the RK time stepping.
M TransportEqns/DQMOMEqn.cc
M TransportEqns/DQMOMEqn.h
- Added upwind and super_bee convection schemes.
- Passing the timesubstep properly now.
- Fixed a sign error in the convection scheme addition to the RHS.
- Perform data copy after a RK step.
M TransportEqns/ScalarEqn.cc
- Passing the timesubstep properly now.
- Added an "if" statement to the sched_initialize (only perform when timesubstep = 0)
- Note: Still need to add flux limiters here.
M ExplicitTimeInt.h
- Now passing alpha and beta into the time averaging method. I was having some weirdness here that should be revisited (potential memory bug?).
M SpatialOps.cc
- Now setting the time integrator for the DQMOM equations. Don't ask me how this actually worked before :p
- Initializing particle velocities in actuallyInitialize.
- Right now there is a bunch of problem specific initialization going on that we will want to generalize in the future.
- Computing stable time step using a convective CFL. Will want to refine this (perhaps a different norm? Add diffusive CFL) soon.
M SourceTerms/SourceTermBase.h
- Passing timesubstep properly now and storing it in the base class.
M SourceTerms/ConstSrcTerm.cc
M SourceTerms/ConstSrcTerm.h
- Adusting to changes made in the base class.
M StandAlone/inputs/UPS_SPEC/spatialops_spec.xml
- Added more spec for the particle velocity model.
100 lines of code changed in 4 files:
Divide the weighted abscissa with the weight to get the right length.
38 lines of code changed in 1 file:
Some bug fixes.
9 lines of code changed in 1 file:
Commenting out unused variables; implementing machinery to differentiate between different internal coordinates for Kobayashi-Sarofim model
96 lines of code changed in 9 files:
Forgot a [c]
1 lines of code changed in 1 file:
Removing comments
2 lines of code changed in 1 file:
M CoalModels/KobayashiSarofimDevol.cc
- Fix most of this to compile... But Charles/Jeremey, y'all are going
to need to go over this function. If nothing else, the commented
out FIXME at the end (looks like there was already a comment there
about work that needs to be done...).
8 lines of code changed in 1 file:
M CCA/Components/SpatialOps/CoalModels/ModelFactory.h
- Reorder constructor initialization of variables to match order that
they are declared in the file. (This removes a compiler warning.)
- Added some cosmetic whitespace.
M CCA/Components/SpatialOps/DQMOM.h
- N_xi and N appear to be (and are used as) unsigned ints, so I made
them unsigned ints.
- Also, couldn't search for 'N' in the file, so I updated it to the
coding standard and named it N_.
- Can't (shouldn't?) put "DQMOM::" in front of function names in the
DQMOM class. (Fixes linux compiler error.)
M CCA/Components/SpatialOps/DQMOM.cc
- Removed "std::" as it is not necessary (using namespace std;).
- Used "unsigned int" as loop var for some N_'s (for consistency and to silence compiler warning).
- Commented out unused variable to silence compiler warning.
M CCA/Components/SpatialOps/SpatialOps.cc
- Commented out unused variable to silence compiler warning.
9 lines of code changed in 1 file:
M CoalModels/BadHawkDevol.cc
M CoalModels/ConstantModel.h
M CoalModels/BadHawkDevol.h
M CoalModels/KobayashiSarofimDevol.h
M CoalModels/ModelFactory.h
M CoalModels/ConstantModel.cc
- Fix compilation errors. Clean up code formatting. Pass arguments
using const and reference to make code faster/cleaner.
- Match 'modelName' parameter's name in both .h and .cc files.
- Some of the parameters appeared to be in a different order from
other files, so made them consistent.
- Don't need ';' in .h files after {} for constructors/destructors.
M CoalModels/KobayashiSarofimDevol.cc
- Seems like there are a lot of compilation problems in this file, so
just commented them out. I'll take another pass in a minute.
59 lines of code changed in 7 files:
Accidentally removed Jeremy's changes to CoalModel's sub.mk...
1 lines of code changed in 1 file:
Adding DQMOM & LU classes to sub.mk file, adding Kobayashi-Sarofim model to sub.mk file, and adding Constant Model class for constant model source terms.
200 lines of code changed in 6 files:
Whoops! Forgot to actually add the model to the tree for the particle velocities.
227 lines of code changed in 2 files:
Added a model for the particle velocities
1 lines of code changed in 1 file:
Adding/updating coal models and model factory to accept field labels, and adding correct Taylor-Green velocity field to SpatialOps.cc
207 lines of code changed in 7 files:
Undoing changes (for real this time)
3 lines of code changed in 4 files:
Undoing ModelBase changes
4 lines of code changed in 6 files:
(6 more)