Lines of Code
[root]/CCA/Components/Arches/CoalModels
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 226 (100.0%) | 9896 (100.0%) | 43.7 |
| charlesreid | 139 (61.5%) | 6322 (63.9%) | 45.4 |
| jthornoc | 61 (27.0%) | 2229 (22.5%) | 36.5 |
| jpedel | 18 (8.0%) | 1339 (13.5%) | 74.3 |
| luitjens | 8 (3.5%) | 6 (0.1%) | 0.7 |
Adding some missing "VarLabel::destroy"s
0 lines of code changed in 4 files:
Hopefully cleaning up a few memory leaks.
8 lines of code changed in 1 file:
Deleting the boundary condition object.
0 lines of code changed in 2 files:
MPMArches.cc:
Moved setAreaFraction from MPMArches.cc to ExplicitSolver.cc (with an "if d_MAlab" -- i.e., only called every time step if mpm is present.)
Arches.cc:
Added WestbrookDryer.h
Added initialization for "extra local labels" for source terms
Added some print statements for the header of the output stream
Added WestbrookDryer model registration
ArchesLabel.cc and .h:
Added a new label for mixture molecular weight (from Table)
BoundaryCond_new.cc:
Fixed a bug with the material index
ExplicitSolver.cc:
Added the setAreaFraction call that was moved from MPMArches
ExplicitTimeInt.h:
Added a check for zero density (inside a wall). I am planning on moving this division by density out of the time integrator and into the scalar eqn where it belongs. More to come...
Properties.cc, NewStaticMixingTable.*, Stream.h:
Added the mixture molecular weight and access to it
SourceTerms/:
Added a new Source Term (WestbrookDryer)
Added a virtual function for initializing the sources and any local dependent functions the source might require
Added "extraLocalLabel" vector for the sources in the base class.
ScalarEqn.cc:
Names the "old" transport label with the correct name.
Initialized Conv and Diff at the start of a time step to zero.
Added the clipping function at the end of the averaging.
Added dummyInit of RHS, FCONV, FDIFF
Grabbing the right old variable for copying in the dummyInit
DQMOMEqn.cc:
Passing in a modifieable weight into getICVariables...we may want to handle the cutoff differently
Initializing Fconv and Fdiff to zero at the start of every t_step.
PartVel.cc:
Changed the default behavior of the particle velocities on the boundary to require (user specified) values from the input file.
1 lines of code changed in 1 file:
Fixing one more compiler warning
1 lines of code changed in 1 file:
Fixing compiler warning
18 lines of code changed in 1 file:
M Directives.h
Making comments more user-friendly
M CoalModels/HeatTransfer.cc
Fixing a problem with unfound tags
7 lines of code changed in 2 files:
Making a tag not required and adding an explanation of it
94 lines of code changed in 1 file:
M CCA/Components/Arches/CoalModels/SimpleHeatTransfer.cc
Fixing compiler warning
M CCA/Components/Arches/TransportEqns/EqnBase.h
Minor edits
M CCA/Components/Arches/TransportEqns/DQMOMEqn.cc
Bulletproofing problemSetup()
M CCA/Components/Arches/DQMOM.cc
Fixing bugs in moment calculation
Rearranging get() calls so they aren't happening at each cell
0 lines of code changed in 1 file:
M CCA/Components/Arches/CoalModels/BadHawkDevol.h
M CCA/Components/Arches/CoalModels/ModelBase.h
M CCA/Components/Arches/CoalModels/ConstantModel.h
M CCA/Components/Arches/CoalModels/Devolatilization.h
M CCA/Components/Arches/CoalModels/HeatTransfer.cc
M CCA/Components/Arches/CoalModels/HeatTransfer.h
M CCA/Components/Arches/LU.h
Minor edits
M CCA/Components/Arches/DQMOM.cc
Removing some timings
M CCA/Components/Arches/CoalModels/DragModel.h
M CCA/Components/Arches/CoalModels/DragModel.cc
Removing conversion functions for velocity (Cartesian <--> spherical) and calling them statically from PartVel class
M CCA/Components/Arches/CoalModels/PartVel.h
Making velocity conversion functions (Cartesian <--> spherical) public and static
M CCA/Components/Arches/CoalModels/SimpleHeatTransfer.cc
M CCA/Components/Arches/CoalModels/SimpleHeatTransfer.h
Using vector length()'s instead of the Cartesian <--> spherical methods
Adding verification procedure
M CCA/Components/Arches/CoalModels/KobayashiSarofimDevol.cc
M CCA/Components/Arches/CoalModels/KobayashiSarofimDevol.h
Adding verification procedure
Adding two sets of constants, one from Kobayashi and one from Ubhayakar
Fixing Y1_ value
M CCA/Components/Arches/CoalModels/CoalModelFactory.cc
M CCA/Components/Arches/CoalModels/CoalModelFactory.h
Adding problemSetup method (to be used in future coupled physics calculations)
Adding method to set ArchesLabel (to be used in future coupled physics calculations)
Building models when they are first added to the build map, as opposed to when they are requested for the first time
M CCA/Components/Arches/Arches.cc
Adding call to set ArchesLabel in CoalModelFactory (to be used in future coupled physics calculations)
M CCA/Components/Arches/TransportEqns/ScalarEqn.h
M CCA/Components/Arches/TransportEqns/ScalarEqn.cc
Adding directives header file
M CCA/Components/Arches/Directives.h
Adding new verification directives
A StandAlone/inputs/ARCHES/Verification/verify_devol_heatxfer_models.ups
Adding input files for running new model verification procedures (it also has working moments for 3 internal coordinates and 4 environments)
M StandAlone/inputs/UPS_SPEC/arches_spec.xml
Updating UPS spec
1109 lines of code changed in 27 files:
Migrated a few more function calls to the new patch interface.
Deleted the old patch interface.
Removed __New() from the new patch interface calls.
6 lines of code changed in 8 files:
Transferring contrl of the model evaluations to the CoalModelFactory.
This will not change answers (no, really, this time I made sure - I fixed the problem with gas-phase source terms).
This transfer will make verification of the model terms easier.
It will also pave the way for implementation of an iterative, coupled particle calculation.
615 lines of code changed in 22 files:
Removed the extra initialization and moved the boundary condition evaluation until after the model is computed.
Also put back a default boolean for particle velocity model.
10 lines of code changed in 1 file:
Reverting CoalModels commit
850 lines of code changed in 15 files:
Getting rid of smoothTfield (was causing problems)
Adding SimpleHeatTransfer to arches UPS spec
0 lines of code changed in 2 files:
Changing the default of particle velcity BCs to be the same as gas velocity BCs
(the inlet velocity should be the same as the gas by default)
(this needs to be fixed so that the inlet boundary condition velocity will be the same as the gas, but the outlet/wall/etc boundary condition velocity will be 0.0)
1 lines of code changed in 1 file:
Adding initialization of smooth temperature field back in (removed accidentally)
6 lines of code changed in 2 files:
Removing comments unrelated to BadHawkDevol class (oops)
0 lines of code changed in 1 file:
1. Changing structure of DQMOM coal model evaluations - this will not change the answers!
Instead of ExplicitSolver calling sched_computeModel for each model, it calls the CoalModelFactory once
The CoalModelFactory then calls sched_computeModel (and computeModel) for each model
This will allow for the later implementation of an iterative method for model calculations
2. Adding Devolatilization and HeatTransfer base classes
The "HeatTransfer" class is no longer a specific model, it s a virtual/base class for any kind of heat transfer model
The existing HeatTransfer class has been moved to SimpleHeatTransfer
This is in anticipation of future heat transfer models being created
Additionally, the HeatTransfer and Devolatilization virtual/base classes implement methods that will be useful when implementing an iterative method for coal particle calculations
(i.e. the iterative multiphysics coal model used in Glacier)
3. Adding Badzioch and Hawksley model back in (but not compiling it, since it's still an empty class)
4. Adjusting the check for model types in Arches.cc
1942 lines of code changed in 18 files:
Arches.cc:
1) Now copying phi into old_phi after initialization at the beginning of the simulation
2) Properly initializing ccVelocity (gas) at the beginning of the simulation
3) Initializing the particle velocity to the gas velocity at the start (we can debate if this is the right way to handle this)
DqMomEqn.cc:
1) Subtracting the Ax=b source instead of zeroing out the RHS (duh!) for the verification procedure
PartVel.cc:
1) Properly initializing the particle velocity at the start of a new timestep
2 lines of code changed in 1 file:
(48 more)