Lines of Code
[root]/CCA/Components/Arches/SourceTerms
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 75 (100.0%) | 1864 (100.0%) | 24.8 |
| jthornoc | 55 (73.3%) | 1572 (84.3%) | 28.5 |
| jpedel | 6 (8.0%) | 237 (12.7%) | 39.5 |
| charlesreid | 9 (12.0%) | 50 (2.7%) | 5.5 |
| luitjens | 4 (5.3%) | 4 (0.2%) | 1.0 |
| jas | 1 (1.3%) | 1 (0.1%) | 1.0 |
Hopefully cleaning up a few memory leaks.
2 lines of code changed in 2 files:
MPMArches.cc:
Moved setAreaFraction from MPMArches.cc to ExplicitSolver.cc (with an "if d_MAlab" -- i.e., only called every time step if mpm is present.)
Arches.cc:
Added WestbrookDryer.h
Added initialization for "extra local labels" for source terms
Added some print statements for the header of the output stream
Added WestbrookDryer model registration
ArchesLabel.cc and .h:
Added a new label for mixture molecular weight (from Table)
BoundaryCond_new.cc:
Fixed a bug with the material index
ExplicitSolver.cc:
Added the setAreaFraction call that was moved from MPMArches
ExplicitTimeInt.h:
Added a check for zero density (inside a wall). I am planning on moving this division by density out of the time integrator and into the scalar eqn where it belongs. More to come...
Properties.cc, NewStaticMixingTable.*, Stream.h:
Added the mixture molecular weight and access to it
SourceTerms/:
Added a new Source Term (WestbrookDryer)
Added a virtual function for initializing the sources and any local dependent functions the source might require
Added "extraLocalLabel" vector for the sources in the base class.
ScalarEqn.cc:
Names the "old" transport label with the correct name.
Initialized Conv and Diff at the start of a time step to zero.
Added the clipping function at the end of the averaging.
Added dummyInit of RHS, FCONV, FDIFF
Grabbing the right old variable for copying in the dummyInit
DQMOMEqn.cc:
Passing in a modifieable weight into getICVariables...we may want to handle the cutoff differently
Initializing Fconv and Fdiff to zero at the start of every t_step.
PartVel.cc:
Changed the default behavior of the particle velocities on the boundary to require (user specified) values from the input file.
595 lines of code changed in 24 files:
Migrated a few more function calls to the new patch interface.
Deleted the old patch interface.
Removed __New() from the new patch interface calls.
4 lines of code changed in 4 files:
Forgot to actually add the new files (MMS1).
Changed = back to += (we need += because of multiple quadrature nodes...) in source terms but now we are initializing the source terms to zero before computing.
181 lines of code changed in 5 files:
1) added a "mms1" source term
2) added extra sources to dqmom equations for verification/debugging
3) added underscores for RHS, Fconv, Fdiff for naming consistency
4) added initialization for "mms1"
5) changed some += to = in a few coal models including coalgasmomentum.cc, coalgasdevol, and constantsrcterm
6) added compiler directive (VERIFY_DQMOM_TRANSPORT) for DQMOMEqn.cc for verification purposes. Note that ScalarEqn.cc doesn't need this because scalars are in general open to an arbitrary number of source terms.
5 lines of code changed in 4 files:
Compiler warning fixes.
1 lines of code changed in 1 file:
- Fixing initialization bugs in DQMOMEqn
- Adding uniform constant/step initialization functions to DQMOMEqn class
- Adding environment-specific constant/step initialization functions to DQMOMEqn class
- Fixing print statements in equation classes to use proc0cout instead of cout
- Fixing several indentation issues in equation classes
The following files had only minor/cosmetic changes:
* PartVel.cc
* ExplicitSolver.cc
* DQMOM.cc
* ExplicitTimeInt.h
* CoalGasMomentum.cc
* CoalGasDevol.cc
* Arches.cc
* ScalarEqn.h
* DQMOMEqn.h
The following files had major changes:
* ScalarEqn.cc
* DQMOMEqn.cc
* EqnBase.cc
6 lines of code changed in 2 files:
Resolving a naming conflict (& getting rid of a bug in DQMOMEqn initialization)
6 lines of code changed in 2 files:
Fixing a few more std::runtime's to Uintah type errors
6 lines of code changed in 1 file:
Several significant changes being made, mainly related to the CoalModels part of Arches. They include:
- Implementing a way for DQMOM model terms to depend on scalars being tracked by the TransportEqn framework
(within the <model> block, internal coordinates required to calculate the model term should go inside the <ICVars> block;
scalar variables required to calculate the model term should go inside the <scalarVars> block)
(this will allow the ability to use scalars in the TransportEqn framework, which will ease the way for tracking flow variables in Arches through the TransportEqn mechanism)
- Modifying ModelBuilder/ModelBase to incorporate BOTH required internal coordinate variables and required scalar variables, instead of JUST required internal coordinate variables
- Changing gas source terms to be uniform (they're now labeled "modelName_gasSource_qn#"), so we don't have a different name for each model (confusing!!!)
- Moving initialization of model term and gas source term from within ModelBase to within the particular model itself (this was done because, for example, the Drag model requires a model and gas source term of type Vector, but others require type double, etc.; this eliminates if statements in ModelBase, keeping it generic)
- Eliminating the Badzioch Hawksley model (it was empty, and is a lower-order model than the Kobayashi Sarofim model, so is not very useful)
- Eliminating (redundant) labels/variables for gas phase source term (the gas phase source term has the label d_gasLabel; if an extra gas phase source term is needed, it should be added within the class that requires it)
- Eliminating (redundant) calls to grab the gas phase source term label (the method used is ModelBase::getGasSourceLabel(); if an extra gas phase source term is added, an access function should be added within the class that requires it)
- (Hopefully!) making the variable label/role tags within DQMOM models a little more clear (see comments)
- Getting rid of MORE hard-coding of "small" weights at 1e-4 (this is somehow proliferating through the code...)
- Adding a method DQMOMEqn::getSmallClip() to grab the value we decide to set as a "small" weight value (this is 1e-16 for now) and implementing in existing models
- Adding input file tag to set the "small" weight value (default is 1e-16)
32 lines of code changed in 4 files:
Undoing some changes.
2 lines of code changed in 2 files:
Adding coupling capability between gas phase and particles
226 lines of code changed in 2 files:
Adding coupling capability between gas and particle phase
11 lines of code changed in 4 files:
DQMOM now works with MPMArches.
70 lines of code changed in 6 files:
1) Changed dqmomEqn to use generic BC's
2) Fixed RK averaging
3) Added clipping mechanism to CCscalar
4) Added initial value mechanism to ccscalar
5) DQMOMinit is now setting the domain to initValue (not boundary).
6) Added a hack for reacting coal. It is commented out.
7) Why do we have a dummyT in Kobayashi model? Now using tempINLabel instead.
5 lines of code changed in 1 file:
Added a sign check for now on the devol. rate.
Fixed a sign error in the eta source term.
1 lines of code changed in 1 file:
1) Added a source term for the coal gas for the eta mixture fraction.
2) Added calculation of the source term in the Kobayashi model.
3) Put a discretization class in EqnBase.
4) Cleaned up some header files.
5) Moved templated functions into header file for Discretization_new
6) Got the dirichlet scalar boundary condition stuff up and running for BoundaryCond_new
7) Added scalar transport equations "sched_eval" to time step algorithm.
8) Added variable density update to ExplicitTimeInt.
9) Some tidying up and variable initialization in Arches.cc
237 lines of code changed in 3 files:
Initial import of the DQMOM solvers into Arches along with a few model terms.
474 lines of code changed in 7 files: