Move d_gravity from SimulationState.h to various components that use it.
49 lines of code changed in 19 files:
changed the logic slightly.
0 lines of code changed in 2 files:
tabs
930 lines of code changed in 56 files:
tabs
2735 lines of code changed in 231 files:
findTabs
This script searches all *.h and *.cc files
and displays all the lines that have tabs in them
If the user adds a "y" to the command line then the tabs
will be converted to spaces.
43 lines of code changed in 1 file:
no more tabs.
471 lines of code changed in 41 files:
no more tabs
4 lines of code changed in 1 file:
no more tabs.
94 lines of code changed in 11 files:
Move d_ref_press from SimulationState.h to ICE.h.
38 lines of code changed in 5 files:
Added a debug stream that outputs the load balance assignments in an easily parsable format.
28 lines of code changed in 1 file:
computeVel_FC()
fixed typo from last commit old_dw -> new_dw for vel_CC mpm_matls
1 lines of code changed in 1 file:
cleanup and clarification
scheduleComputeVel_FC()
- no longer passing in flag recursion. That flag is always false
computeVel_FC()
- removed recursion conditional statement
impICE.cc
scheduleRecomputeVel_FC()
- added if(recursion) conditional to clarify what's going on
27 lines of code changed in 5 files:
minor cleanup, removed duplicate code.
Now using scheduleAddExchangeContributionToFCVel() in impICE.
* should not change the answers
16 lines of code changed in 2 files:
Several significant changes being made, mainly related to the CoalModels part of Arches. They include:
- Implementing a way for DQMOM model terms to depend on scalars being tracked by the TransportEqn framework
(within the <model> block, internal coordinates required to calculate the model term should go inside the <ICVars> block;
scalar variables required to calculate the model term should go inside the <scalarVars> block)
(this will allow the ability to use scalars in the TransportEqn framework, which will ease the way for tracking flow variables in Arches through the TransportEqn mechanism)
- Modifying ModelBuilder/ModelBase to incorporate BOTH required internal coordinate variables and required scalar variables, instead of JUST required internal coordinate variables
- Changing gas source terms to be uniform (they're now labeled "modelName_gasSource_qn#"), so we don't have a different name for each model (confusing!!!)
- Moving initialization of model term and gas source term from within ModelBase to within the particular model itself (this was done because, for example, the Drag model requires a model and gas source term of type Vector, but others require type double, etc.; this eliminates if statements in ModelBase, keeping it generic)
- Eliminating the Badzioch Hawksley model (it was empty, and is a lower-order model than the Kobayashi Sarofim model, so is not very useful)
- Eliminating (redundant) labels/variables for gas phase source term (the gas phase source term has the label d_gasLabel; if an extra gas phase source term is needed, it should be added within the class that requires it)
- Eliminating (redundant) calls to grab the gas phase source term label (the method used is ModelBase::getGasSourceLabel(); if an extra gas phase source term is added, an access function should be added within the class that requires it)
- (Hopefully!) making the variable label/role tags within DQMOM models a little more clear (see comments)
- Getting rid of MORE hard-coding of "small" weights at 1e-4 (this is somehow proliferating through the code...)
- Adding a method DQMOMEqn::getSmallClip() to grab the value we decide to set as a "small" weight value (this is 1e-16 for now) and implementing in existing models
- Adding input file tag to set the "small" weight value (default is 1e-16)
1310 lines of code changed in 22 files:
Changed short to long to allow us to move onto larger machines.
0 lines of code changed in 2 files:
Undoing some changes.
2 lines of code changed in 2 files:
Reverting some recently committed code.
0 lines of code changed in 7 files:
Removed debugging statement.
0 lines of code changed in 1 file:
Adding coupling capability between gas phase and particles
685 lines of code changed in 4 files:
Adding coupling capability between gas and particle phase
152 lines of code changed in 13 files:
The reacting coal kludge is no longer needed in Arches.cc.
0 lines of code changed in 1 file:
Now the velocity model is not a function of a local eta. Rather, it is set from the input file. Still trying to figure out what exactly Balanchandar meant by eps because if one uses eta = (nu^3/eps)^(1/4) to compute the kolmogorov scale you get some funky velocities.
21 lines of code changed in 2 files:
Try to avoid some potential integer wraping.
9 lines of code changed in 2 files:
Change some math to long long to avoid wrapping.
0 lines of code changed in 2 files:
DQMOM now works with MPMArches.
802 lines of code changed in 22 files:
Updates to the particle velocity model.
1) u_l is now a local velocity
2) added an iterative procedure
44 lines of code changed in 2 files:
Revert revision 44731
59 lines of code changed in 16 files:
Move d_ref_press and d_gravity from SimulationState.h to the MPM and ICE
components.
99 lines of code changed in 15 files:
Move d_thermalConductivity from Material.h to MPMMaterial.h and ICEMaterial.h.
14 lines of code changed in 8 files:
Remove d_specificHeat from Material.h to MPMMaterial.h and ICEMaterial.h.
17 lines of code changed in 7 files:
Remove unused d_heatTransferCoefficient and getHeatTransferCoefficient().
0 lines of code changed in 2 files:
Move d_includeFlowWork from Material.h to MPMMaterial.h and ICEMaterial.h.
49 lines of code changed in 7 files:
Turn off frictional heating effects by default. This is what the comment has
said, but it is not what it was doing. This may break the RT.
4 lines of code changed in 1 file:
added bulletproofing.
0 lines of code changed in 2 files:
Added some spec for the velocity model and added an input for changing the regime.
15 lines of code changed in 2 files:
Adjusted the LBTimes SCI_DEBUG.
15 lines of code changed in 1 file:
Added more error metrics
19 lines of code changed in 2 files:
Small fix to error calculation
2 lines of code changed in 1 file:
Changed the error metric to sMAPE
7 lines of code changed in 2 files:
Fixed compiler warnings.
Added boundary conditions for particle velocity.
Fixed some bugs in heat transfer model.
377 lines of code changed in 11 files:
Fixed a dummyT -> tempIN label issue.
1 lines of code changed in 1 file:
Missed a temperature->gas_temperature change
1 lines of code changed in 1 file:
Added a check for division by zero.
12 lines of code changed in 1 file:
Removed "if" debugging statement adjusting temperatures in loop.
0 lines of code changed in 1 file:
Formatting on HeatTransfer.cc
Changed dummyT to tempIN for HeatTransfer.cc
Clarified "gas_temperature" in both Kobayashi and Heat Transfer models.
41 lines of code changed in 2 files:
Made some corrections for visualizing periodic data
45 lines of code changed in 1 file:
Minor output changes.
Use Kalman Filter.
14 lines of code changed in 4 files:
Changed the way radiation is turned on or off in the particle heat transfer model and added information to the spec.
13 lines of code changed in 1 file:
Adding a flag to have non-adiabatic particles but adiabatic gas.
21 lines of code changed in 7 files:
Using tempIN instead of dummyT, since d_reactingFlow is now true for reacting coal cases (dummyT still needs to be used for non-reacting cases)
5 lines of code changed in 1 file:
Added some auto-clipping for the abscissa value calculation in case the low clip value set by the user = 0.0
3 lines of code changed in 1 file:
Initializing the enthalpy correctly when an initial value of mixture fraction is specified for the entire domain.
14 lines of code changed in 1 file:
Removed a function that wasn't being used.
Templated velocity in the computeConv to aid in verifying the code with other, possibly user specified, velocity fields. (ie, not const).
7 lines of code changed in 1 file:
Added code to use a kalman filter instead of a fading memory filter (currently disabled).
24 lines of code changed in 2 files:
Fixed a couple bugs (Thanks Dav!!!!)
Properties: Use appropriate error catching
Discretization_new: Actually return a value from getFaceVelocity
15 lines of code changed in 2 files:
M Properties.cc
I am assuming that the only proven/working radiation model in the code right now is DO radiation. Thus, radiation is activated now by adding the <DORadiationModel> node. Per this change, calc_radiation is no longer needed. Cases without <DORadiationModel> will not have radiation.
********************************
M CoalModels/ConstantModel.cc
M CoalModels/ConstantModel.h
Constant model now uses a constant specified in the input file. <constant>value</constant>
********************************
M TransportEqns/DQMOMEqn.cc
Initialized the RHS to zero for each time step and use the new discretization class for computing the convection.
********************************
M TransportEqns/Discretization_new.h
Revamped the entire class and removed a few bugs in the process, hopefully in an effort to make this class more modular to all types of transport equations.
********************************
M TransportEqns/ScalarEqn.cc
Initialized the RHS to zero for each time step.
********************************
M BoundaryCond_new.h
Activated the Y and Z dimension compiler directives. Added the Neumann condition.
********************************
M EnthalpySolver.cc
Initialize radiation and DOradiation flags to false. Now looks for DORadiation node and sets d_DORadiation to true if this node is found.
********************************
M ExplicitTimeInt.cc
M ExplicitTimeInt.h
Time integration order is now specified with a first, second, or third order attribute in the ExplcitIntegrator node. Alpha and beta coefficients are set by the code rather than the user.
*******************************
M Radiation/DORadiationModel.cc
The linear solver type (hypre or petsc) is now an attribute of the LinearSolver node.
*******************************
M Arches.cc
Modifications to deal with the Explicit time integrator order specification. Removed some debugging that had been accidently committed earlier.
*******************************
Also updated arches_spec and input files to deal with the new input.
1257 lines of code changed in 13 files:
Removed excessive output to the terminal
3 lines of code changed in 1 file:
Fixed the crash with vector data
22 lines of code changed in 1 file:
Added some more statistical measures.
37 lines of code changed in 2 files:
Fixing some messed-up formatting and some variable names that were misleading
22 lines of code changed in 1 file:
Adding input file check for LU solver tolerance (and changing the default...)
13 lines of code changed in 1 file:
Fixing some messed-up formatting
13 lines of code changed in 1 file:
Compute and output the MAPE error metric.
Automatically detect some rank deficient matrices and remove those parameters from the model.
158 lines of code changed in 4 files:
Added bulletproofing.
Throw an exception if the user specified a computational doman length that is <= 0
in any of the directions.
8 lines of code changed in 1 file:
update input file
0 lines of code changed in 2 files:
set v to NULL if no match region found.
3 lines of code changed in 1 file:
Added extraCells to the cost model.
Added a fading memory filter to the CostModelForecaster.
21 lines of code changed in 7 files:
Now uses least squares approximation to compute the coefficients of the cost model.
The computation is done by computing the normal equations (AT*A) and then solving the corresponding matrix using choleskey's algorithm.
187 lines of code changed in 3 files:
Initial commit of a new cost forecaster that is based on least squares regression analysis using a cost model and profiling.
This is currently incomplete as the matrix solve is not being done.
296 lines of code changed in 6 files:
Add NC_CCweight carry forward.
19 lines of code changed in 1 file: