January 2015 Commit Log

Number of Commits:
90
Number of Active Developers:
12
jthornoc 2015-01-29 13:26 Rev.: 53050

WallHeatFlux calculator added.

Derek and Jeremy debugged the vanleer limiter to get it working.

274 lines of code changed in 10 files:

jas 2015-01-28 17:42 Rev.: 53049

Merge r53048 changes from UintahRelease_1_6_0 for properly specifying the branch for RadProps.

0 lines of code changed in 2 files:

derekhar 2015-01-27 21:05 Rev.: 53045

Adjusting hard coded sizes for radprops in arches.

2 lines of code changed in 1 file:

derekhar 2015-01-27 20:53 Rev.: 53044

Adjusted invoking of radprops slightly to be more correct.

4 lines of code changed in 2 files:

jsutherland 2015-01-27 20:41 Rev.: 53043

Update Arches & Wasatch, which broke due to the recent RadProps API change. For now this just hard-codes values for particle sizes to the values which were previously hard-coded within RadProps.

6 lines of code changed in 2 files:

jthornoc 2015-01-27 18:05 Rev.: 53041

Group the total number density calculation with the pre-update particle
tasks. Clean up the interface for CQMOM.

14 lines of code changed in 3 files:

jthornoc 2015-01-27 17:41 Rev.: 53040

Ack...add missing files.

228 lines of code changed in 2 files:

jthornoc 2015-01-27 17:01 Rev.: 53039

Add a calculator for computing the total number density from the
weights.

10 lines of code changed in 2 files:

jthornoc 2015-01-27 17:01 Rev.: 53038

Actually add the particle convection files.

269 lines of code changed in 2 files:

jthornoc 2015-01-27 17:00 Rev.: 53037

Start of a particle convection-only model.

2 lines of code changed in 3 files:

guilkey 2015-01-27 15:56 Rev.: 53035

Added a compute for pRefinedLabel to scheduleInitialize

1 lines of code changed in 1 file:

ahumphrey 2015-01-27 15:43 Rev.: 53034

Cosmetic change to last commit.

2 lines of code changed in 1 file:

ahumphrey 2015-01-27 15:41 Rev.: 53033

Fix behavior of sus runs started without mpirun.

* sus -nthreads 2 -gpu input.ups (Unified scheduler with GPU support)
* sus -nthreads 2 input.ups (ThreadedMPI scheduler)
* sus input.ups (SingleProcessor scheduler)

37 lines of code changed in 1 file:

ahumphrey 2015-01-27 13:34 Rev.: 53031

Use Unified scheduler if -nthreads is combined with -gpu.

Default behaviour is now:
------------------------------
* mpirun -np 1 sus-dbg-gpu -mpi -nthreads 2 -gpu input.ups (Unified scheduler)
* mpirun -np 1 sus-dbg-gpu -mpi -nthreads 2 input.ups (ThreadedMPI scheduler)
* mpirun -np 1 sus-dbg-gpu -mpi input.ups (MPI scheduler)

There is now need to specify SCI_DEBUG flags or add any spec to input file.

1 lines of code changed in 1 file:

ahumphrey 2015-01-27 13:16 Rev.: 53030

Fix bug with SingleProcessorScheduler (SPS) subscheduler. We can now use this scheduler for any sus run without MPI. This avoids one of the MPI schedulers having to act as a SPS, cleans things up a bit and keep specific functionality contained where it shold be.

This should also fix the failing ICE and UCF tests on the RT machine.

Now sus runs behave as follows WRT schedulers
---------------------------------------------------
* sus input.ups (SingleProcessorScheduler with SingleProcessorScheduler subscheduler)
* mpirun -np <n> sus input.ups (MPIScheduler with MPI subscheduler)
* mpirun -np <n> sus -mpi input.ups (same as above ^^^^^^^^^^^^^^^^)
* mpirun -np <n> sus -mpi -nthreads <nt> input.ups (ThreadedMPISchedule rwith ThreadedMPISchedule subscheduler)

Unified and Dynamic schedulers can be turned on via input file specification or via SCI_DEBUG flag. An easy fix for GPU users to follow soon.

98 lines of code changed in 7 files:

ahumphrey 2015-01-26 23:46 Rev.: 53029

Let ThreadedMPIScheduler do the work of the SingleProcessorScheduler (SPS) until we can fix the SPS subscheduler issues.

22 lines of code changed in 2 files:

dav 2015-01-26 19:41 Rev.: 53028

fixes

5 lines of code changed in 1 file:

awabboud 2015-01-26 16:40 Rev.: 53027

Change how 0 nodes are handled in cqmom inversion

77 lines of code changed in 1 file:

ahumphrey 2015-01-26 15:05 Rev.: 53025

Invoke SingleProcessorScheduler when not using MPI (e.g. "sus inputs/ICE/advect.ups").

3 lines of code changed in 1 file:

jas 2015-01-26 12:34 Rev.: 53023

Made the following changes:

1. Compress large xml files. Remove sus log.

2. Add Changelog.

3. Add instructions for adding a new component to the build system.

4. Update OSX build in install documentation.

5. Update petsc version in install documentation.

6. Change Petsc version.

7. Remove references to Teem in installation. Remove the build directory
after creating the tarball for the release.

8. Remove Tracker feature.

9. Remove AIX references. Remove Basis/. Remove Teem. Remove sci_defs
include files related to SCIRun.

10. Remove old build dependency versions.

11. Add wasatch_3P 1.6.0 branch.

12. Remove bench.config file, update excludes when building release tar ball.

13. Remove *.orig and *.release files.

14. Update copyright date. Update version to 1.6.

2806 lines of code changed in 3744 files:

jas 2015-01-26 11:26 Rev.: 53021

Fix incorrect symlinks for cavityFlow_d*.ups, and remove pinWheel.ups since it pointed to an invalid users home directory.

0 lines of code changed in 6 files:

jholmen 2015-01-24 20:30 Rev.: 53019

* Merge CPUAffinity and MICCompactAffinity to a single CompactAffinity environmental flag.
* Update environmentalFlags.txt to reflect changes in this commit.

35 lines of code changed in 3 files:

ahumphrey 2015-01-24 18:58 Rev.: 53017

* Make ThreadedMPI scheduler the defaullt multi-threaded scheduler
* Now bind control/main thread to last physical core. This avoids some confusing index nonsense
* A little more cleanup in associated supporting classes,
* Update environmentalFlags.txt to reflect changes in this commit.

82 lines of code changed in 10 files:

jthornoc 2015-01-23 18:19 Rev.: 53016

Fixing boundary issues with the new rate/weight/abscissa clipping
approach.

42 lines of code changed in 4 files:

ahumphrey 2015-01-23 17:06 Rev.: 53013

* Cleanup scheduler DebugStreams.
* Document new SCI_DEBUG flags for fine-grained MPI timimgs.

14 lines of code changed in 4 files:

guilkey 2015-01-23 15:33 Rev.: 53012

Add a computes for pRefinedLabel to ImpMPM::scheduleInitialize.

1 lines of code changed in 1 file:

dav 2015-01-23 15:21 Rev.: 53011

Cosmetic cleanups.

35 lines of code changed in 2 files:

dav 2015-01-23 15:08 Rev.: 53010

Fix svn co command in README. Remove hard path to cmake calls.

38 lines of code changed in 6 files:

ahumphrey 2015-01-23 14:27 Rev.: 53008

Only report subscheduler CPU affinity information for proc 0

13 lines of code changed in 2 files:

awabboud 2015-01-23 14:26 Rev.: 53007

Fix drag model for zero diameter nodes.

14 lines of code changed in 1 file:

ahumphrey 2015-01-23 14:00 Rev.: 53006

Fix subcheduler threadID bug.

36 lines of code changed in 2 files:

ahumphrey 2015-01-23 12:19 Rev.: 53004

Some missing additions to CPU affinity reporting in threaded schedulers.

18 lines of code changed in 2 files:

jas 2015-01-23 11:54 Rev.: 53003

Remove empty directories.

0 lines of code changed in 2 files:

ahumphrey 2015-01-23 11:54 Rev.: 53002

Fix CPU affinity reporting in threaded schedulers.

29 lines of code changed in 2 files:

derekhar 2015-01-23 11:43 Rev.: 53001

Made slight efficiency improvement to coal heat transfer model.

9 lines of code changed in 1 file:

jthornoc 2015-01-23 11:36 Rev.: 53000

Adding 2nd order upwind and QUICK schemes.

333 lines of code changed in 1 file:

jas 2015-01-23 11:34 Rev.: 52999

Remove empty Arches directories.

0 lines of code changed in 2 files:

ahumphrey 2015-01-23 03:28 Rev.: 52998

Final round of scheduler cleanup:
* Clean up the class hierarchy, correct virtual overloads, fixed hiding of overloads, etc.
* Removed miles of redundant code.
* Common MPI scheduler-based functionality is in MPIScheduler, where it should be.
* Stacks of formatting, white space, comments, better header documentation.
* Further cleanup/streamlining of MPIStats reporting.
* .... probably more, but this should do it for now.

1106 lines of code changed in 12 files:

guilkey 2015-01-22 17:25 Rev.: 52997

The addParticles function now knows how to refine particles, based on a
(currently) hardwired criterion.

scheduleAddParticles is now called from within a conditional based on a new MPM flag.

Added a pRefinedLabel, so that particles only get refined once, for now.

Got rid of pdTdtLabel_preReloc. This variable is never used from previous
timesteps, so there is no point in dragging it around. Modified the CMs
(all 3e72 of them) accordingly. This will break the RT, as it will have one
fewer checkpoint variable.

289 lines of code changed in 42 files:

jthornoc 2015-01-22 14:41 Rev.: 52995

Add some new input files. Set new RT tests using these input files.

8 lines of code changed in 1 file:

jthornoc 2015-01-22 14:31 Rev.: 52994

Pass an independent lower weight limit in the birth model.

9 lines of code changed in 2 files:

ahumphrey 2015-01-22 13:46 Rev.: 52993

Updated documentation in UnifiedScheduler header.
Some cleanup too.

35 lines of code changed in 1 file:

derekhar 2015-01-22 13:18 Rev.: 52992

Added a feature for users running DO Radiation with scattering so that they can switch the number of ordinates in the middle of a production run.

107 lines of code changed in 5 files:

jthornoc 2015-01-22 11:40 Rev.: 52991

Arches Task Interface
* remove the booleans to control task execution. This is now determined
by the size of the variable registry.

DQMOM
* For the no-solve method, remove requirement for moment specification
* Allow weights to have a non-zero source term (birth)
* Fix a couple bugs in the SimpleBirth model

Other
* Change the constant particle model to be constant/environment

169 lines of code changed in 14 files:

dav 2015-01-21 19:14 Rev.: 52990

Almost done.

14 lines of code changed in 4 files:

dav 2015-01-21 18:50 Rev.: 52989

More cleaning up and testing of the W3P standalone build scripts.

65 lines of code changed in 5 files:

jthornoc 2015-01-21 17:52 Rev.: 52988

Make sure there is no gas coupling as this is a particle birth term.

1 lines of code changed in 1 file:

jthornoc 2015-01-21 17:47 Rev.: 52987

* Renamed a DQMOM function.
* Added a new model term for representing simple particle birth.
* Changed the (new) constant particle model to have a
constant/environment.

380 lines of code changed in 22 files:

dav 2015-01-21 15:06 Rev.: 52985

Initial commit of standalone Wasatch 3p build scripts.

301 lines of code changed in 8 files:

jthornoc 2015-01-21 12:57 Rev.: 52983

Fix a couple bugs in choosing the new limiters with the "wall model".

50 lines of code changed in 1 file:

ahumphrey 2015-01-21 02:03 Rev.: 52981

A second pass on scheduler cleanup.
Much better reporting on task queue algorithm, use (or not) of combined MPI messages
Additional documentation on scheduler-related SCI_DEBUG flags.
More code formatting for readability, alphabetize #includes, white space, line up params/args, {}s, etc.
Remove stacks of old (and mostly bogus) debug code that was comented out.

314 lines of code changed in 17 files:

jthornoc 2015-01-20 23:07 Rev.: 52980

Fix input file for RadPropsPlanck.

Add flux limiters with a "wall model".

256 lines of code changed in 1 file:

jholmen 2015-01-20 15:59 Rev.: 52979

* Updated documentation for environmental flags specific to the ThreadedMPIScheduler and UnifiedScheduler.

19 lines of code changed in 1 file:

tsaad 2015-01-20 12:46 Rev.: 52977

minor changes to the temporal order script

2 lines of code changed in 1 file:

jthornoc 2015-01-19 21:50 Rev.: 52976

Add scaling constants/environment. This will only change answer on the
coal_channel test.

479 lines of code changed in 25 files:

ahumphrey 2015-01-19 18:25 Rev.: 52975

Significant scheduler cleanup, formatting, { }s.
This is the beginning of a full cleansing of the scheudler class hierarchy, etc.

974 lines of code changed in 9 files:

guilkey 2015-01-18 22:03 Rev.: 52973

Rough draft of particle addition/refinement. The scheduleAddParticles in
scheduleTimeAdvance is commented out.

225 lines of code changed in 2 files:

allen 2015-01-16 16:58 Rev.: 52972

Created macro boolean for determining if processor 0 and thread 0

8 lines of code changed in 1 file:

tsaad 2015-01-16 14:17 Rev.: 52971

first cut at a generalized spatial order calculation script. This script does not require an analytical solution! Simply point it to your ups file and you're ready to go (see description to learn about the commandline arguments).
To Do: Support staggered fields
Pitfalls: You are likely to run into trouble when the temporal and spatial orders are tightly coupled via source terms and other quantities. It is recommended that you use a very small timestep.

218 lines of code changed in 1 file:

harman 2015-01-15 15:08 Rev.: 52969

Compute the average of

TaskWaitCommTime:ave, TaskExec:ave, TaskLocalComm:ave

over N timesteps if these data are in the output files.


53 lines of code changed in 1 file:

guilkey 2015-01-14 09:40 Rev.: 52967

Undo removal of the pTempPrevLabel to get the RT off it's back.

1 lines of code changed in 1 file:

jholmen 2015-01-13 20:30 Rev.: 52965

* Increased MAX_THREADS to 241 for the Xeon Phi (KNC).

* Added the MICCompactAffinity environmental flag to the ThreadedMPIScheduler and UnifiedScheduler. This is used to enable compact affinity with specific main/control thread placement for the Xeon Phi (KNC).

* Updated documentation for the CPUAffinity and MICCompactAffinity environmental flags.

*Updated ExecTimes note to correctly reflect the number of threads that it is cumulative over for the ThreadedMPIScheduler and UnifiedScheduler.

37 lines of code changed in 5 files:

allen 2015-01-13 15:10 Rev.: 52962

removed the old udareader

2 lines of code changed in 2 files:

tsaad 2015-01-13 12:20 Rev.: 52961

fix bug when specifying custom particle position label.

26 lines of code changed in 5 files:

guilkey 2015-01-13 11:58 Rev.: 52960

Remove require for pTempPrevLabel. Not used in the explicit code.

0 lines of code changed in 1 file:

awabboud 2015-01-13 11:27 Rev.: 52958

Remove some old couts

0 lines of code changed in 3 files:

ahumphrey 2015-01-12 19:23 Rev.: 52956

Add centralized, multi-threaded MPI scheduler. This resolves issues arising from multiple threads doing MPI recvs, e.g. MPI buffers getting allocated for a receive that didn't occur, duplicated MPI communicators, etc.

Further, relevant scheduler documentation to follow.

1276 lines of code changed in 11 files:

tsaad 2015-01-12 11:52 Rev.: 52954

consolidate the definition of the parabolic function for basic expressions and bc expressions.

34 lines of code changed in 2 files:

ahumphrey 2015-01-12 10:48 Rev.: 52953

* Fix comment typo.
* Remove benign, but clumsy copy/paste mistake in Unified Scheduler.
* Add in missing UPS <Scheduler> options for DW when using VarTracker (example below).

e.g.
-------------------
<Scheduler type="DynamicMPI">
<VarTracker>
<var label="abskg" dw="CoarseOldDW"/>
<locations before_comm="false" before_exec="true" after_exec="true"/>
<task name="Ray::rayTrace"/>
</VarTracker>
</Scheduler>

7 lines of code changed in 2 files:

jas 2015-01-10 11:29 Rev.: 52952

Squashed commit of the following:

commit b51e0ae5c15312447f4995150d369180d1cb6ac6
Author: John Schmidt <john.schmidt@utah.edu>
Date: Sat Jan 10 10:26:55 2015 -0700

The iterator is present if either the node or cells list is non-zero.

1 lines of code changed in 1 file:

jthornoc 2015-01-08 13:14 Rev.: 52947

GOODBYEEEEEE

(remote debugging print statement)

0 lines of code changed in 1 file:

jthornoc 2015-01-08 13:14 Rev.: 52946

Add a coal db helper.
Add the coal mass clip model.
Start using specific task groups for particle models.
Turn back on rmcrt local tests.

336 lines of code changed in 8 files:

jthornoc 2015-01-08 13:14 Rev.: 52945

Adding a new coal clipping model to ensure the rates aren't forcing
overshoot on the mass.

38 lines of code changed in 8 files:

ahumphrey 2015-01-08 10:41 Rev.: 52944

A first round of cleanup in the effort to support spatial task scheduling.
* Added many { } around one-line conditionals, etc.
* Removed ancient commented-out debug code (specific to some problem ages ago).
* Some formatting and added whitespace for readbility.
* Added an assertion in UnifiedScheduler to check for correct thread-IDs when reading from the MPI comm records (sends).
* Removed redundant DebugStream in Unified Scheduler
* Significant, general cleanup in TaskGraph code.

606 lines of code changed in 7 files:

harman 2015-01-07 18:01 Rev.: 52943

Removed global materialSet variable (_matlSet), using

sharedStated->allArchesMaterials()

instead.

6 lines of code changed in 2 files:

jthornoc 2015-01-07 17:10 Rev.: 52941

Moving particle models to a better home.
This shouldn't change answers.

1443 lines of code changed in 32 files:

guilkey 2015-01-07 16:10 Rev.: 52939

Move carry forward of NC_CCweight outside of loop over matls, since it
only exists for matl 0.

15 lines of code changed in 1 file:

guilkey 2015-01-07 12:30 Rev.: 52938

Get rid of a bunch of tabs and other uglified code.

56 lines of code changed in 1 file:

allen 2015-01-06 17:39 Rev.: 52937

added a new interface to get the particle name

6 lines of code changed in 1 file:

jthornoc 2015-01-06 16:03 Rev.: 52935

Retab.

388 lines of code changed in 38 files:

jthornoc 2015-01-06 14:54 Rev.: 52934

Retab and reindent.

274 lines of code changed in 2 files:

jthornoc 2015-01-06 14:36 Rev.: 52933

Fix this silliness.

4 lines of code changed in 1 file:

jthornoc 2015-01-06 13:04 Rev.: 52932

More warning cleanup. Shouldn't change answers.

15 lines of code changed in 8 files:

dav 2015-01-05 18:49 Rev.: 52927

Two files that should have gone in with previous commit.

20 lines of code changed in 2 files:

dav 2015-01-05 18:41 Rev.: 52926


These are code readability (cosmetic) fixes. A bunch of coding
standards, white space, untabbifying, adding needed {}, and variable
alignment fixes, etc. This includes naming class variables with trailing
'_' (or using 'd_' depending on the way other variables in the file
are named) so that we know they are class variables.

This should not change any answers.

M CCA/Components/Schedulers/CommRecMPI.cc
M CCA/Components/Schedulers/CommRecMPI.h
M CCA/Components/Schedulers/UnifiedScheduler.h

- d_id renamed to d_thread_id.
- A lot of these functions should be virtual... It is confusing as to what is supposed to be
inherited, what is overridden, etc. Someone needs to clean up the entire Scheduler class hierarchy.

M CCA/Components/Schedulers/MPIScheduler.h
M CCA/Components/Schedulers/UnifiedScheduler.cc
M Core/Parallel/PackBufferInfo.cc
M Core/Parallel/BufferInfo.cc
M Core/Parallel/PackBufferInfo.h

- One line functions in .h files traditionally are written on one line (so that the file reader
sees the important information (member function names) and is not immediately distracted by
the implementation).

M Core/Parallel/BufferInfo.h


545 lines of code changed in 9 files:

jthornoc 2015-01-05 18:18 Rev.: 52925

Fix a memory problem.
Turns out that the retrieve_task function was always building the task
rather than looking to see if it had previously been built. This is
corrected in this commit. Shouldn't change the answers but should fix
the failing memory test.

19 lines of code changed in 2 files:

jthornoc 2015-01-05 18:17 Rev.: 52924

Clean up warnings.
This won't change answers.

227 lines of code changed in 38 files:

harman 2015-01-05 15:06 Rev.: 52922

Added "./" prior to the call to the script.

3 lines of code changed in 1 file:

derekhar 2015-01-05 13:26 Rev.: 52921

Fixed warnings. Comparisons between int and unsigned int.

3 lines of code changed in 2 files:

harman 2015-01-05 12:19 Rev.: 52919

- added preprocessor conditional statement around sheduling radiometer with spatial scheduling enabled.
- only schedule task on patches with radiometer cells.

46 lines of code changed in 1 file:

December 2014 »

Generated by StatSVN 0.7.0