Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 19 (100.0%) | 36 (100.0%) | 1.8 |
| dav | 7 (36.8%) | 23 (63.9%) | 3.2 |
| jas | 10 (52.6%) | 10 (27.8%) | 1.0 |
| jthornoc | 2 (10.5%) | 3 (8.3%) | 1.5 |
OSX Snow Leopard fixs from Dav. (First OSX to truely support 64 bits.)
M include/sci_defs/osx_testdefs.h.in
OSX Hack isn't used any more, so I removed it. Added the snow leopard #define.
M CCA/Components/Schedulers/OnDemandDataWarehouse.h
No one uses the boundary layer parameter so I removed it.
M CCA/Components/Schedulers/TaskGraph.h
- Removed tabs messing up indentation.
- Made a few params 'const'.
M CCA/Components/Schedulers/TaskGraph.cc
- Mostly cosmetics:
- Added some white space.
- Added some {}.
- Made a few params 'const'.
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- An undefined boundary layer was being passed in even though no one uses it, so
default it to 0,0,0.
M CCA/Components/Schedulers/SchedulerCommon.cc
- Use 'const'.
M CCA/Ports/DataWarehouse.h
- Indent.
- In allocateTemporary(), you can't give a reference parameter (boundaryLayer) a default value. Not
sure why this compiles on other machines.
M Core/Grid/Patch.h
- White space cosmetics.
M Core/Grid/Variables/ParticleVariableBase.h
M Core/Grid/Variables/ParticleSubset.h
- Can't have a function differentiated only by return type (and particularly just by 'const' on the return type).
Not sure why other compiles allow this, and/or which function they actually 'link in', but the OSX 10 compiler
doesn't like it.
M Core/Grid/Variables/ReductionVariable_special.cc
- Don't compile some of these things under snow leopard.
M Core/Grid/Variables/ParticleVariableBase.cc
- Cosmetics.
M Core/Thread/Thread.cc
- Fix a warning for John. ;)
M Core/Disclosure/TypeUtils.cc
- 64 bit functions that become multiply defined if left in for Snow Leopard.
M Core/Util/Endian.cc
- White space!
M StandAlone/sub.mk
- Need Core/OS to link.
M StandAlone/tools/puda/varsummary.cc
- 64 bit overloaded function fix for OSX snow leopard.
M configure.ac
- OSX snow leopard fixes.
- NOTE: Not checking in configure because I don't have the correct autoconf version on this
machine. I will fix this in the next commit (coming shortly).
3 lines of code changed in 2 files:
Allow for building 'sus' (et al) statically. Use the configure flag: --enable-static. For the most
part, you will not want a static build. However, in two cases you might:
1) To check for circular dependencies in the code. (Dynamic libs are forgiving in this regard.)
2) For machines that don't support shared libs (eg: AIX, some new micro-kernel Linux clusters, etc.)
Unfortunately when static linking, library order is important. There is no good way (that I know of)
to tell our build system to place the libs in a specific order, so I have hardcoded the libraries
that are necessary to static link each executable. (See CORE_STATIC_PSELIBS and CORE_STATIC_LIBS in
configVars.mk.)
Note, SUS previously build statically for AIX and Redstorm. A number of hard coded #defines for these
architectures have been replaced with more general code.
If a source code file needs to know that it is building statically (most won't, but some do), then it
will need to #include <sci_defs/compile_defs.h> and use the "STATIC_BUILD" #define'd var.
Some specific notes:
M testprograms/TestMatrix3/testmatrix3.cc
Since it is used in a library, it can't have a "main()" (as this causes two mains to show up when linking).
M configure.ac
- Go back to using 'autoconf' version 2.61 as the standard as it is available many places, and I can't
find 2.63 anywhere.
- Fixed a few uses of a $var that would cause shell script errors when not defined. (Placed it withing ""
so that it becomes an empty string (as opposed to a missing string).
5 lines of code changed in 3 files:
Added info about the combination of libraries.
0 lines of code changed in 2 files:
Remove sgi woff ifdefs.
0 lines of code changed in 1 file:
Combined Core/Math, Core/Disclosure, and Core/Geometry into one
library (with respect to linking (at least for now)) in order to get
around the circular dependency problem we are having under OSX... (and
on any other machine where we need to build static libraries.) Had to
add Core/Math to the PSELIBS line of a number of sub.mk files.
Currently all the files are compiled into the Core/Math library (but
still exist in their original locations). I created dummy.cc files to
allow me to still create the Core/Disclosure and Core/Geometry
libraries (which are now basically empty) so that I didn't have to
update all the sub.mk files to remove these references. However, at
some point in the near future, this needs to be cleaned up.
M Core/Persistent/Persistent.cc
For some reason Persistent.cc was #including <Endian.cc> which caused
symbols to appear twice. I changed this to #include the .h file.
This shouldn't be an issue... and may have only shown up (now, instead
of years ago) because I don't have TEEM turned on right now (TEEM used
to be on by default). (With TEEM turned on, Persistent.cc uses nrrd.h
for endian stuff.)
M CCA/Components/Arches/MCRT/ArchesRMCRT/RMCRTRRSDStratified.cc
Replaced 100000000000000000 with DBL_MAX, so that compilations on 32
bit machines don't error out.
18 lines of code changed in 2 files:
Remove sgi_stl_warnings include line
0 lines of code changed in 3 files:
Remove the Packages/Uintah/
9 lines of code changed in 5 files:
Remove the Packages/Uintah/
1 lines of code changed in 1 file: