Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 104 (100.0%) | 1507 (100.0%) | 14.4 |
| dav | 13 (12.5%) | 727 (48.2%) | 55.9 |
| tsaad | 11 (10.6%) | 528 (35.0%) | 48.0 |
| ahumphrey | 5 (4.8%) | 99 (6.6%) | 19.8 |
| jas | 55 (52.9%) | 67 (4.4%) | 1.2 |
| knolla | 4 (3.8%) | 51 (3.4%) | 12.7 |
| harman | 5 (4.8%) | 20 (1.3%) | 4.0 |
| sidharth | 6 (5.8%) | 10 (0.7%) | 1.6 |
| allen | 5 (4.8%) | 5 (0.3%) | 1.0 |
added new output ports
0 lines of code changed in 2 files:
white space clean up
5 lines of code changed in 1 file:
added a force regridding option, added access methods to the sim controller, added regridding option to the libsim
0 lines of code changed in 2 files:
PIDX cmpression support
3 lines of code changed in 2 files:
No checkpoint with PIDX enabled + enable option to rite lower resolution
5 lines of code changed in 1 file:
PIDX support if configured with --with-pidx option : works only for CCtype grids
2 lines of code changed in 3 files:
Added method:
bool isRestartInitTimestep()
A component can query the scheduler and determine if it is the initial timestep after
a restart.
AMRSimulationController: run()
- moved
bool first = true;
if (d_restarting) {
d_scheduler->setRestartInitTimestep(first);
}
upstream, before doInitialTimestep().
2 lines of code changed in 2 files:
1. Fix a few bugs in the Hypre solver interface for asymmetric matrices
2. Allow components to specify whether a matrix is symmetric or not. This should done via, for example, sParams->setSymmetric(true). To check for symmetry use getSymmetric()
0 lines of code changed in 2 files:
Namespace cleanups.
14 lines of code changed in 6 files:
added PIDX code to DataArchiver
51 lines of code changed in 4 files:
Tested on Ash, BigMac, and Aurora.
Fixes for Tony S. so that new routines can be placed in SolverInterface.cc.
Here is the fix for placing code from SolverInterface.h into SolverInterface.cc.
The two issues fixed with this commit are 1) Added SolverInterface.cc to the
list of files to compile, and 2) added Core/Math to the list of
libs that must be linked (as it was missing), both in sub.mk
M Ports/SolverInterface.cc
M Ports/SolverInterface.h
- Moved some new functions from the .h file into the .cc file.
- Align, remove tabs, clean up.
M Ports/sub.mk
- Add SolverInterface.cc to list of files to compile.
- Align, remove extra spaces, alphabetize, make eaiser to follow, remove duplicate lib listings.
- Added Core/Math to the list of libs to link against.
335 lines of code changed in 5 files:
Eliminate compiler warning about comparison between signed and unsigned integer expressions.
1 lines of code changed in 1 file:
Revert ""
This reverts commit 730400d0fb991f08d4dd64212d7909ac9d89e88b.
219 lines of code changed in 3 files:
Fixes for Tony S. so that new routines can be placed in SolverInterface.cc.
M SolverInterface.cc
M SolverInterface.h
- Moved some new functions from the .h file into the .cc file.
- Align, remove tabs, clean up.
M sub.mk
- Add SolverInterface.cc to list of files to compile.
- Align, remove extra spaces, alphabetize, make eaiser to follow.
329 lines of code changed in 3 files:
Propagate the solvability constraint through Wasatch.
This is controlled by the user: Simply add <EnforceSolvability/> to the <Pressure> xml block.
Start deprecating the reference pressure setup and replace with
the new approach.
Loosen up the tolerance on a few tests to help Hypre converge.
This commit will fail a few RT tests with machine diffs.
32 lines of code changed in 1 file:
remove a couple of cout statements
0 lines of code changed in 1 file:
allow the solvability constraint to work with multistage integration.
The issue stems from doing multiple reductions on the same
variable - something that Uintah doesn't allow.
Therefore, one needs to use a different varlabel everytime
a reduction is required, on a given variable, within the same timestep.
55 lines of code changed in 1 file:
Forgot to delete varlabel.
Remove check for periodicity from the task that enforces solvability.
The user/developer must determine when to call that task.
4 lines of code changed in 1 file:
Add a top-level task to the Solver base class that allows users/developers to set a reference value
for the Poisson equation.
The function is super simple to use given a solver instance:
solver.scheduleSetReferenceValue( level, sched, matls, xLabel, refCell, refValue)
xLabel is the varlabel of the solution vector (e.g. pressure)
refCell is an IntVector designating the reference cell and defaults to [0,0,0]
refValue is a double designating the reference value and defaults to 0.0
This task MUST be called AFTER scheduleSolve
102 lines of code changed in 1 file:
Add a top-level task to the linear solver that enforces the solvability condition for the Poisson equation in periodic problems.
This task can be called by ALL components given an instance of a solver.
It will only execute on periodic problems (all 3 dimensions).
Simply use: solver.scheduleEnforceSolvability<rhsType >(level, sched, matls, rhs_label)
where rhsType is the Uintah data type of the Poisson rhs: e.g. CCVariable<double> etc...
This task MUST be called before the scheduleSolve task.
116 lines of code changed in 1 file:
For now, turn off per level support for maxGhostCells. This will allow the large-scale DDT simulations on Mira to advance using threaded-schedulers. We can revisit this issue when time permits.
3 lines of code changed in 1 file:
Temp. fix for LoadBalancer bug that was causing AMR MPMICE to hang.
This will enable forward progress with threaded schedulers on the Gordon Bell effort related to Jacqueline's DDT problem.
7 lines of code changed in 1 file:
Added scheduleRestartInitialize() to the framework. It's currently disabled, waiting for Alan's mods.
12 lines of code changed in 2 files:
OnDemandDataWarehouse.cc/.h
Added new method (getLevel()) for getting data for all patches on a level.
This is a specialization of getRegion() and is substantially faster on large patch counts runs.
RMCRT:
Replaced getRegion() call with getLevel()
6 lines of code changed in 1 file:
This is a recommit of the XML memory usage fix commit that was
committed a month ago (at and around ~r52896), but had a few errors
with respect to a handful of tests (AMR/multi-level?) This has passed
the local RT though there are a few tests that are off by 10e-15 or
so.
M CCA/Components/LoadBalancers/LoadBalancerCommon.cc
M CCA/Components/LoadBalancers/LoadBalancerCommon.h
- Combined a number of pieces of the ParticleLoadBalancer and DynamicLoadBalancer
into LoadBalancerCommon.
- The getOldProcessorAssignment() call previously was implemented in the
CCA/Ports/LoadBalancer.h file, but this was confusing as that should just
be an interface. Placed the 'dynamic' version (used by both Particle and
Dynamic Load Balancers) in this file. Simple and SingleProcessor overwrite
with their own simple version.
- addContribution(), finalizeContributions() resetCostForecaster() and
initializeWeights() are now here (not in the Port LoadBalancer.h
interface anymore) and provide a warning that they actually aren't
doing anything when they are not.
- Removed some old code that was there to read in (old) UDA 1.0s.
- Lined up variables, white space, {}, coding standards, etc.
M CCA/Components/LoadBalancers/DynamicLoadBalancer.h
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc
M CCA/Components/LoadBalancers/ParticleLoadBalancer.h
M CCA/Components/LoadBalancers/ParticleLoadBalancer.cc
- getPatchwiseProcessorAssignment() and getOldProcessorAssignment() moved into
LoadBalancerCommon.
- Marked a number of 'virtual' functions with the virtual key word.
M CCA/Components/LoadBalancers/SimpleLoadBalancer.h
M CCA/Components/LoadBalancers/SimpleLoadBalancer.cc
M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.h
M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.cc
- Implemented getOldProcessorAssignment() here so it would be more clear
where this function is implemented (instead of being buried in the Port interface).
- White space.
M CCA/Components/MPM/ImpMPM.cc
- All cosmetic white space / coding standards updates, with the exception of fixing this bloc:
// Pull out from Time section
d_initialDt = 10000.0;
ProblemSpecP time_ps = restart_mat_ps->findBlock("Time");
if( time_ps ) {
time_ps->get("delt_init",d_initialDt);
}
Added the "if( time_ps )" check. The reason this is necessary is that
the "Time" block no longer exists in the restart_mat_ps portion of the
restart problem spec. (This is due to no longer loading the XML DOM.)
In the above (and previous) code, if "delt_init" is not found, then
10000 is used as a default. [Actually, I'm not quite sure why this is
done, or how this was working, but it 'works' the same now as it did
before.]
M CCA/Components/ProblemSpecification/ProblemSpecReader.h
M CCA/Components/ProblemSpecification/ProblemSpecReader.cc
- Added the readInputFile() function that reads and parses the input UPS file
directly, but does not save the XML DOM (this is done because on huge
simulations with 10Ks of patches, the XML DOM was taking 100s of MB of
memory... now we just get the information out of the file that we need
without saving it).
M CCA/Components/Schedulers/DetailedTasks.h
- Fix naming to use our convention (well, one of them, in this case
the trailing '_' for member variables).
M CCA/Components/Schedulers/DetailedTasks.cc
- Fix indentation, white space.
- Using 'using namespace std' for consistency will all our other .cc files.
M CCA/Components/Schedulers/MPIScheduler.cc
- White space, variable line up.
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Removed the non-used parameters from getOldProcessorAssignment().
- White space, variable line up.
M CCA/Components/Schedulers/SchedulerCommon.h
- Pass strings as const & - don't copy.
M CCA/Components/Schedulers/SchedulerCommon.cc
- Use proc0cout instead of separate if.
- Remove tabs.
M CCA/Components/Schedulers/TaskGraph.cc
- Removed the non-used parameters from getOldProcessorAssignment().
M CCA/Components/Schedulers/UnifiedScheduler.cc
M CCA/Components/SimulationController/AMRSimulationController.cc
- White space.
M CCA/Components/SimulationController/SimulationController.cc
- Line up variables, white space, {}s.
- Renamed "restart_prob_spec" as it is now only the portion of the
restart PS that pertains to the component and thus is now named
"restart_prob_spec_for_component".
M CCA/Ports/LoadBalancer.h
- Organize #includes, white space.
- Make all functions in this interface pure virtual so that they will
be implemented 'closer to home'.
M CCA/Ports/Scheduler.h
- Line up variables, white space, pass strings as const &.
M Core/Containers/HashTable.h
- Move "first()" call into constructor as everywhere in the code when
ever one of these was created, first() was immediately called.
M Core/DataArchive/DataArchive.h
- No longer creating the giant (for 10K+ patches) XML DOM objects.
Instead, parse them directly for the information needed and pass
that around.
- Pass strings as const &.
- White space, capitalization, line up variables, {}s, etc.
- More passing const variables as const.
- d_tsindex becomes the more readable d_ts_index, etc.
- DataArchive needs the Load Balancer now in order to know where patches belong.
M Core/DataArchive/DataArchive.cc
- Organize #includes.
- White space, etc.
- Add UPS file parsing codes for parsing as we stream through the file.
- UDAs (the xml) are actually read in in several phases. Previously because
they were read into an XML DOM data structure, we just passed that around
and it didn't make a difference. Now we have to be smarter about what
is read when.
- Fix the outputting of restart UPS files (previously the old restart information
was lost).
- Renamed variable Url to Filename as that is what it is.
M Core/Grid/Variables/ComputeSet.h
- Fix spacing.
M Core/ProblemSpec/ProblemSpec.h
M Core/ProblemSpec/ProblemSpec.cc
- Added XML parsing via streaming file functions.
- Fix spacing.
- Added constructor that will create a ProblemSpec from data in a buffer.
- This is used when we parse an input UPS file and need (small) parts
of it still as an UPS file (eg, to be passed down to a component
so that we don't have to change component code at this point).
M StandAlone/compare_uda.cc
M StandAlone/tools/compute_Lnorm_udas.cc
- Due to extra linking requirements, we need to init the Uintah Parallel
library before running (even if the initialization just tells the
library that it is not running under MPI) using these calls:
Uintah::Parallel::determineIfRunningUnderMPI( argc, argv );
Uintah::Parallel::initializeManager(argc, argv);
- Fix #includes.
- Coding standard updates.
M StandAlone/sus.cc
- Space out the exception handling to make the code easier to follow.
30 lines of code changed in 2 files:
Cosmetic fix while looking at getting list of variables from DW for Allen's invitro VisIt updates.
2 lines of code changed in 1 file:
More incremental updates to get the code ready for the XML memory fix.
These changes have passed the optimized localRT, but the debug version was throwing
strange errors due to a newer compiler having bad interactions with sci malloc.
I'm currently running a work-around on those and if the debug build displayes
real problems, I'll back these changes out.
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc
M CCA/Components/LoadBalancers/DynamicLoadBalancer.h
M CCA/Components/LoadBalancers/LoadBalancerCommon.cc
M CCA/Components/LoadBalancers/LoadBalancerCommon.h
M CCA/Components/LoadBalancers/ParticleLoadBalancer.cc
M CCA/Components/LoadBalancers/ParticleLoadBalancer.h
Consolidated a lot of duplicate code from ParticleLoadBalancer and DynamicLoadBalancer and put it into
the LoadBalancerCommon. For example, restartInitialize() and useSFC() were both duplicate code. There
are probably others routines/variables that could be consolidated.
Note, the #define SFC_PARALLEL was turned on in Particle LB, but not Dynamic LB, so not sure which one
is 'correct'. I do note that it does change the answers (slightly) for the Arches RT tests.
Some code clean ups, alphabetize #includes, use "d_" for class variables, etc.
M CCA/Ports/LoadBalancer.h
- Made restartInitialize 'port' purely virtual so it has to be implemented... before, an 'empty' version could be called
causing confusion on what was actually happening.
M CCA/Ports/SFC.h
- Code layout/cosmetic update.
M Core/DataArchive/DataArchive.cc
31 lines of code changed in 2 files:
Made the following changes:
1. Compress large xml files. Remove sus log.
2. Add Changelog.
3. Add instructions for adding a new component to the build system.
4. Update OSX build in install documentation.
5. Update petsc version in install documentation.
6. Change Petsc version.
7. Remove references to Teem in installation. Remove the build directory
after creating the tarball for the release.
8. Remove Tracker feature.
9. Remove AIX references. Remove Basis/. Remove Teem. Remove sci_defs
include files related to SCIRun.
10. Remove old build dependency versions.
11. Add wasatch_3P 1.6.0 branch.
12. Remove bench.config file, update excludes when building release tar ball.
13. Remove *.orig and *.release files.
14. Update copyright date. Update version to 1.6.
53 lines of code changed in 49 files:
Final round of scheduler cleanup:
* Clean up the class hierarchy, correct virtual overloads, fixed hiding of overloads, etc.
* Removed miles of redundant code.
* Common MPI scheduler-based functionality is in MPIScheduler, where it should be.
* Stacks of formatting, white space, comments, better header documentation.
* Further cleanup/streamlining of MPIStats reporting.
* .... probably more, but this should do it for now.
53 lines of code changed in 1 file:
Significant scheduler cleanup, formatting, { }s.
This is the beginning of a full cleansing of the scheudler class hierarchy, etc.
35 lines of code changed in 1 file: