Author | Changes | Lines of Code | Lines per Change |
---|---|---|---|
Totals | 29 (100.0%) | 59 (100.0%) | 2.0 |
qymeng | 5 (17.2%) | 35 (59.3%) | 7.0 |
harman | 15 (51.7%) | 14 (23.7%) | 0.9 |
jsutherland | 6 (20.7%) | 5 (8.5%) | 0.8 |
jthornoc | 2 (6.9%) | 3 (5.1%) | 1.5 |
ahumphrey | 1 (3.4%) | 2 (3.4%) | 2.0 |
This one has been a long time coming.
Rip out the standard namespace opening that has been polluting header files throughout the framework. This crept into all sorts of places.
DO NOT open namespaces in header files. Ever.
5 lines of code changed in 6 files:
[Dav de St. Germain commit via Jeremy's account/git:]
The following commit fixes a problem with the way Fortran files are
added into the Uintah framework. As you may know, the perl script
'fspec.pl.in' reads in a fortran spec file (eg: bcuvel.fspec) and
converts it into a .h file (bcuvel_fort.h), converting things such as
IntVectors into arrays of integers (etc) in order to pass Uintah
variables back and forth with the fortran code. To use the fortran
code, the generated .h file is included into a Uintah .cc file and the
function is called. Compilation problems arose when the fortran .h
file was included before a blanket "using namespace Uintah" appeared.
This was because the generated fortran .h file did not use the correct
"Uintah::" namespace qualifiers, and instead relied on some other file
to open up the namespace. I have fixed the script to now use
"Uintah::" correctly. Additionally, I have removed a lot of namespace
polluting "using namespaces" from around the code.
CCA/Components/Arches/Arches.cc
CCA/Components/Arches/CompDynamicProcedure.h
CCA/Components/Arches/IncDynamicProcedure.h
- Clean up due to "using namespace std" being removed from included .h file.
CCA/Components/Arches/Radiation/DORadiationModel.cc
CCA/Components/Arches/Source.cc
- Clean up due to "using namespace std" being removed from included .h file.
- Some better indentation.
- Put all _fort.h includes next to each other.
CCA/Components/Arches/water/watertp.h
CCA/Components/Models/FluidsBased/ArchesTable.cc
CCA/Ports/SFC.h
Core/Exceptions/InvalidCompressionMode.h
Core/Exceptions/InvalidValue.h
Core/Exceptions/ProblemSetupException.h
Core/Exceptions/UintahPetscError.h
Core/IO/SpecializedRunLengthEncoder.h
Core/Math/Short27.h
- Remove polluting "using namespace" from .h file.
CCA/Components/LoadBalancers/CostModelForecaster.cc
CCA/Components/LoadBalancers/CostModelForecaster.h
- Indentation, spacing.
- Use 'd_' for a class variable to be consistent with rest of class.
Core/Grid/Variables/Variable.cc
StandAlone/Benchmarks/SimpleMath.cc
StandAlone/tools/pfs/rawToUniqueGrains.cc
- Move "using namespace" into the .cc file as it was removed from the .h files.
tools/fspec.pl.in
- Make the perl script include the "Uintah::" for Uintah
variables so that a "using namespace Uintah" statement is not
required.
3 lines of code changed in 2 files:
First wave of refactoring for RMCRT to use the new Unified Scheduler GPU-DataWarehouse interface.
This is essentially all the "external plumbing". Internal work will be to next re-write the rayTrace kernel to fit with the recent CPU-RMCRT changes.
2 lines of code changed in 1 file:
Implemented a lightweight version of GPUDataWarehouse, GPUGridVariable and GPUArray3D inside GPU.
This commit included a new set of interfaces for better supporting GPU task.
See example in Examples/UnifiedSchedulerTest
17 lines of code changed in 1 file:
Removed the last remnants of the "addMaterial" code. It hasn't been used for years.
1 lines of code changed in 6 files:
removed scheduleInitializeAddedMaterial()
- It hasn't been used in 5+ years.
1 lines of code changed in 2 files:
- Added scheduleRefine() to the ModelInterface
- Adde a call to scheduleRefine in AMRICE
- Defined the refine task for the DDT1 burn model
9 lines of code changed in 4 files:
Removed some old rotted out plumbing:
- scheduleCheckNeedAddMaterial()
- activateModel()
This idea died and blew away years ago.
* should not change answers
1 lines of code changed in 2 files:
put checkpoint/output interval value from ups file into the dw
if the variable doest not exsit, such as during the init timestep.
5 lines of code changed in 1 file:
More descriptive variable names
outputInv -> outputInterval
checkpointInv -> checkpointInterval
updateCheckpointInterval()
using d_checkpointInterval instead of d_outputInterval in conditional
2 lines of code changed in 1 file:
Allow user defined task to change outputInterval and checkpointInterval
Example:
schedule:
task->computes(shareState->get_outputInterval_label())
shareState->updateOutputInterval(true);
task function:
newdw->put(min_vartype(newvalue), shareState->get_outputInterval_label());
6 lines of code changed in 1 file:
rename coarsenDelt task name to reduceSysVar
call MPI reduce directly from reduceSysVar task
4 lines of code changed in 1 file:
Add preGridProblemSetup() for simulation component to allow problem setup before grid setup.
Add setExtraCell() to Grid class, this method can only be called when grid has not setup.
3 lines of code changed in 1 file: