Lines of Code
[root]/CCA/Components/Wasatch/Expressions/Turbulence
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 96 (100.0%) | 2279 (100.0%) | 23.7 |
| tsaad | 67 (69.8%) | 1767 (77.5%) | 26.3 |
| jsutherland | 29 (30.2%) | 512 (22.5%) | 17.6 |
First major cut at enthalpy transport with heat loss in Wasatch. We still need to couple in the radiation terms, but the hooks are in place.
5 lines of code changed in 4 files:
A few misc changes:
- Create a default constructor for TurbulenceParameters to avoid dependence on initialization in Wasatch.cc.
- remove “forcedIDs” from GraphHelperTools since it wasn’t really being used.
- misc. improved error trapping.
13 lines of code changed in 2 files:
Clean up a few compiler warnings in Wasatch that were showing up on gcc 4.8.
7 lines of code changed in 2 files:
Minor changes to DynamicSmagorisnkyCoefficient:
- Use inline Nebo implementation of BoxFilter.
- Make GPU runnable.
- inline in a few places where possible
- remove a cone use in favor of an if statement for better efficiency.
- Release a few temporary fields to reduce the memory footprint slightly.
99 lines of code changed in 3 files:
Convert line endings in some recently committed Wasatch files from CRLF to LF.
192 lines of code changed in 2 files:
Updates due to an API change in SpatialOps.
193 lines of code changed in 1 file:
Commit on Abhishek's behalf. Minor changes getting some things ready for Wasatch to use GPUs.
51 lines of code changed in 4 files:
This is a major (and beautiful) commit for Wasatch. It entails a complete refactoring of the boundary conditions for ease of use, efficiency (?), and the new Nebo syntax for handling masks (e.g. BC iterators) in general. Some of the things were changed in this commit include:
1. ripping out the functor_name from the uintah boundary condition suite. those are now set in the <value> tag of the boundary condition.
2. converting all boundary conditions to use ijk indexing instead of flat. Nebo will eventually do its magic behind the scenes.
3. A new BCHelper class that manages all boundary conditions, their iterators, names etc...
4. A pre-processing step on input files to guarantee that <Face> specification has a unique name. This pre-processing step will automatically rename duplicates or put unique names if the user has not specified any.
A key assumption for this new approach is centered around the <Face> specification as being a single boundary condition - that is, you MUST specify ALL relevant boundary conditions within the same <Face> spec.
1 lines of code changed in 1 file:
1. Change the NONE enum for TurbulenceModelName to NOTURBULENCE.
2. Allow the TaskInterface to lockAllFields by passing a boolean flag. This may be needed in Warches to avoid cherry-picking locked fields.
3 lines of code changed in 3 files:
Add a break statement to quiet a warning.
1 lines of code changed in 1 file:
- Rework the nomenclature in the DensityCalculator to be more understandable.
- Many other changes to the DensityCalculator to improve efficiency and readability.
- Update property parsing to be a bit more compact
- fix a stray character in a comment in StrainTensorMagnitude.h
1 lines of code changed in 2 files:
Update some doxygen stuff.
2 lines of code changed in 1 file:
- for expressions that are ready for GPU execution, advertise this fact in their constructor. Note that this means that we must start to be very careful about putting anything in an evaluate() method that may break this!
- more cleanup.
15 lines of code changed in 1 file:
Add regression test for adaptive timestepping. cleanup Wasatch.py. cleanup a few DynamicSmagorinskyCoefficient and StableTimestep expressions. Allo Warches to do BC treatment on the Wasatch turbulent viscosity.
10 lines of code changed in 3 files:
Do not use getWithDefault for the eddy viscosity so as to avoid conflict with need_applies_to. Also, grab the timestep size from the old_dw instead of setting it manually. This will remove the Uintah warning - lowering delt from 1 to max - at every timestep.
2 lines of code changed in 1 file:
simplify the Turbulence specification.
2 lines of code changed in 1 file:
Additional optimizations in Wasatch: Get rid of initializations for the pressure rhs, turbulent viscosity, Wale model denominator, and ScalarRHS. Inline a few expressions in ScalarRHS and get rid of some obsolete commented code in DiffusiveVelocity.cc
0 lines of code changed in 1 file:
Even more optimizations to the StrainTensorMagnitude calculation. A couple of typedefs to simplify declarations.
17 lines of code changed in 4 files:
Cleanup temporary fields and initializations in the Dyanmic model. This reduced the cpu time by 4-to-8% depending on tested patch sizes (32^2 or 16^3, respectively).
15 lines of code changed in 2 files:
Simplify TurbulenceModels interface by using a velocity TagList instead of individual velocity tags. Disallow using a Turbulence model in 1 or 2 dimensions.
52 lines of code changed in 6 files:
rename a few tensor components in WALE and Vreman models to conform to the original papers.
17 lines of code changed in 1 file:
Major cleanup of the StrainTensorMagnitude. Removed ALL temporary fields as well as initialization. This should hopefully produce a noticeable speedup.
28 lines of code changed in 1 file:
Cleanup obsolete comments throughout Wasatch. Inline WallDistance expression. Rename a few members of the TurbulenceParameters struct.
44 lines of code changed in 7 files:
- Simplify some syntax to use a new FieldManagerList::field_ref() function where it makes sense to do so.
- minor clean up.
73 lines of code changed in 5 files:
Update syntax.
6 lines of code changed in 1 file:
Make sure the turbulent viscosity never goes < 0 when extrapolating at patch boundaries. Enforce the extrapolation of the strain-tensor magnitude to never go < 0. Catch a bug in the variable density dynamic model where I was multiplying by the density twice. Add an option to the dynamic model to do extra-filtering of the resulting expressions - this is still experimental and can only be turned on by developers.
37 lines of code changed in 3 files:
Fix some stylistic problems...
46 lines of code changed in 2 files:
Make the extrapolant even more robust by allowing developers to specify the minimum and maximum allowable values for extrapolated quantities. I also should clarify the comment on my previous commit: I meant to say that allowing the extrapolant to skip physical boundaries will help in avoiding negative values for the viscosity which are causing Warches issues. With this commit however, we can have a more robust control over extrapolation, even at physical boundaries.
6 lines of code changed in 1 file:
allow extrapolant to skip physical boundaries. This caused problems with Warches when calculating the turbulent viscosity at the boundary because it was leading to negative values in the extra-cells.
1 lines of code changed in 1 file:
Add variable-density effects to the dynamic-model. Use SpatFldPtr vectors to redcue the dynamic-model's code and make it look nicer and hopefully more readable. It is MUCH easier to make changes now. NOTE: there are no verification cases for the variable density dynamic model at the moment. This means that the model will likely require fine-tuning so keep that mind when running variable density turbulent simulations using the dynamic model.
203 lines of code changed in 2 files:
vanquish a few demons in the dynamic-Smagorinsky expression. this should now play nicely with boundary conditions.
50 lines of code changed in 2 files:
Replace StringNames with TagNames to simplify access to commonly used tags.
0 lines of code changed in 6 files:
This is a major Wasatch commit. First, the viscosity is removed from the stress tensor calculation so that it becomes a strain tensor. This separation helps us reuse the strain tensor in LES models yielding a noticeable speedup. Second, as the viscosity is moved into the momentum RHS calculation, one must exrapolate its values at all patch boundaries - this lead to the development of an extrapolant operator that takes care of this extrapolation. One could of course perform and MPI communication on the turbulent viscosity but this was twice as costly as the extrapolation. Furthermore, the extrapolant will be used in the dynamic smagorinsky model to fill in ghost-cell values before filtering operations. Finally, a few cosmetic changes here and there to make the code look nice. NOTE: this commit will break every Wasatch test that solves the momentum equations - as expected - due to the change in the algebraic operations order. All differences are of the order of machine precision except for the turbulence tests due to the extrapolation.
154 lines of code changed in 4 files:
improve the stability of the dynamic coefficient calculation.
31 lines of code changed in 1 file:
get rid of the Kolmogorov scale user input. Please revise your input files if you are using any of the Wasatch turbulence models by simply deleting the KolmogorovScale xml spec under the Turbulence block. Alternatively, you can use remove_xml_block for batch removal of xml blocks (see: inputs/Wasatch/remove_xml_block). This commit will break ALL WASATCH TURBULENCE regression tests.
4 lines of code changed in 3 files:
modify exception handling for the dynamic model
1 lines of code changed in 1 file:
Add a dynamic Smagorinsky model to Wasatch. This model currently operates for constant density flows. variable density handling will be committed soon. Verificaiton and regression tests will also follow.
889 lines of code changed in 9 files:
update documentation for the strain tensor magnitude.
8 lines of code changed in 1 file: