Lines of Code
[root]/CCA/Components/Arches/PropertyModels
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 109 (100.0%) | 1269 (100.0%) | 11.6 |
| awabboud | 12 (11.0%) | 618 (48.7%) | 51.5 |
| jthornoc | 85 (78.0%) | 602 (47.4%) | 7.0 |
| harman | 1 (0.9%) | 27 (2.1%) | 27.0 |
| ahumphrey | 2 (1.8%) | 13 (1.0%) | 6.5 |
| jsutherland | 9 (8.3%) | 9 (0.7%) | 1.0 |
Removing the _has_been_computed bool.
41 lines of code changed in 12 files:
This one has been a long time coming.
Rip out the standard namespace opening that has been polluting header files throughout the framework. This crept into all sorts of places.
DO NOT open namespaces in header files. Ever.
9 lines of code changed in 9 files:
Get rid of a memory error with the constant property.
0 lines of code changed in 2 files:
More label cleanup.
The normalized scalar variance model was simplified to only compute the
normalized value of scalar variance. The absolute value of variance was
removed.
Now requiring soot for DO radiation model (for properties).
6 lines of code changed in 4 files:
Removing the _has_been_computed boolean usage.
15 lines of code changed in 2 files:
Cleaning out the last of the dummies in Arches.
0 lines of code changed in 31 files:
Add a var label to the normalized scalar variance model, so that the raw scalar variance value can be used elsewhere.
20 lines of code changed in 2 files:
Remove unused variable to silence complier warning.
0 lines of code changed in 1 file:
Add in the source term and property model required for the 2-equation scalar variance model.
248 lines of code changed in 4 files:
Further improve ARCHES multi-threaded output
8 lines of code changed in 1 file:
Make ARCHES multi-threaded table/property/model output more coherent.
5 lines of code changed in 1 file:
Add in the property models for the scalar variance, and the source term required for a 1-eqn model.
350 lines of code changed in 5 files:
Some code went missing in IntrusionBC.cc...it has been put back. This might be the cause of the chronic Arches test failures (heptane, coal pipes.)
Fix a warning in HeatLoss.cc
7 lines of code changed in 1 file:
Deduce the sensible and adiabatic enthalpy names from the heat loss
model if the user hasn't saved them to the UDA.
3 lines of code changed in 1 file:
Fixing a couple issue with the coal variable transformation.
Force a table lookup for adiabatic enthalpy when inerts are used.
12 lines of code changed in 1 file:
More bug fixes related to heat loss:
1) Order HL last for cases where hl = f( other property models)
2) Don't compute heat loss in walls.
60 lines of code changed in 2 files:
Fixing an error with the new scalar variance implementation to return
zero when in walls.
Moving the heptane_pipe and coal_pipe RT tests over to ARCHES and
modernizing the input files.
14 lines of code changed in 1 file:
More broken function calls in TabPropsInterface.
Updating HeatLoss model to remove some debugging and to add flexibility.
16 lines of code changed in 2 files:
* Not forcing a hard coded name on the particle absorption coefficient.
* Added a new variable transformation for single mixture fraction cases.
* Adiabatic enthalpy is now computed via the mixture fraction to force consistency with the enthalpy equation. Previously a table lookup on adiabatic enthalpy was being used which 1) was slow and 2) was lagged in time by dt which caused artificial heat loss. Note this requires that users specify the fuel and oxidizer enthalpies in the table itself using the KEY/value tokens in the table header when using the heat loss model.
* Trim an unused transform
* allocate the property model vars independently from the compute function. Updated all property models accordingly.
* updated some input files accordingly
146 lines of code changed in 11 files:
Simplifying the var transform proceedure by passing the inert mass
fraction for all cases.
Getting the inerts to the heat loss model.
29 lines of code changed in 2 files:
Pass a reference of the mixing table to the heat loss model.
6 lines of code changed in 1 file:
Updated the scalar variance model to actually do something.
Committed some new updated input files with the latest and greatest.
86 lines of code changed in 2 files:
Heat loss bounds are now automatically set to the table grid bounds
rather than letting the users specify them.
19 lines of code changed in 4 files:
Fixed a restart bug with the empirical soot model. Also added some
bulletproofing for label matching.
Allowed user to specify a non-zero value when using the geometry_fill
option for initializing scalars.
Updating input files to reflect the changes.
25 lines of code changed in 1 file:
** Warning ** Monolithic commit **
1) Always recompile taskgraph on restart until restartInitialize lives up to its name.
2) Adding new variable transforms for the table lookup: rcce, rcce_fp, fcce_eta. These are still somewhat incomplete and should be used with caution.
3) Clipping on the RK averaging to actually allow variables to go to zero: This may change answers!!
4) In EmpSoot, make sure you specify the correct radiation model.
5) Some major reworking of the Westbrook dryer model. This should fix some of the mass balance issues seen in some cases.
6) Changed how the clipping is specified for some variables. Note that <small> was removed from the DQMOM option in favor of a more universal <tol>
1 lines of code changed in 1 file:
Adding access to commonSetup for the constant property model.
2 lines of code changed in 1 file:
Call common problem setup for this model.
1 lines of code changed in 1 file:
This allows you to compute heat loss, but use a constant value when
doing table look ups. This is useful for debugging and verification
work.
113 lines of code changed in 2 files:
sched_computeProp() & computeProp()
The scheduling of the variables is now consistent with what is done in the task.
inputs/ARCHES/RMCRT/methane_rmcrt.ups now runs on multiple patches per
core.
removed tabs.
formatting.
27 lines of code changed in 1 file: