Lines of Code
[root]/CCA/Components/Arches/TransportEqns
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 56 (100.0%) | 1086 (100.0%) | 19.3 |
| jthornoc | 54 (96.4%) | 1066 (98.2%) | 19.7 |
| harman | 2 (3.6%) | 20 (1.8%) | 10.0 |
Comments.
0 lines of code changed in 2 files:
Now passing material id into new boundary condition interface rather
than the entire ArchesLabel set.
Applying BCs for heat loss.
1 lines of code changed in 2 files:
added printScheduling() & printTasks().
20 lines of code changed in 2 files:
Removing the extra boundary treatment occurring for diffusive fluxes. This was originally done to make the new stencil operations match the old Arches transport code. Since this old method adds extra work at boundaries and sane arguments can be made for this update, I am going ahead and breaking from tradition.
Viva la revolution!
0 lines of code changed in 2 files:
Created a common initialization method for all property models. This
fixed a bug in how property models were being initialized. This will
cause some answers to change due to the initial condition.
Also fixed a bug for transported variables that are initialized using a
table lookup. In this case, boundary conditions weren't being reapplied
which will also cause some answers to change.
Finally updated some input files to conform to new standard.
12 lines of code changed in 2 files:
EqnBase.h: Fix a bug in the initialization to use point->getCellPosition rather
than trying to compute it locally.
BCUtil: Fix a memory bug that showed up when doing strict memory
testing.
8 lines of code changed in 1 file:
** Big Changes **
1) Added more access function to BC data in BCUtil. This should help in determining if <value> is a double, string, or vector. I didn't see any previous method that provided this information.
2) ClassicTables now require explicit definitions of each independent variable, model, through either <TransportEqn> or <PropertyModel> definitions in the input file. (currently scalar variance is the one exception, where the old normalizedScalarVar can still be used).
3) Added a <PropertyModel> for heat_loss.
4) Transport equations can now have a "Tabulated" attribute spec for boundary conditions. The <value> should be specified as the string identifier for the dependent variable the user wants to use as the boundary condition. Note that this only works for Dirichlet conditions as Neumann conditions don't require a table lookup.
5) Transport equations can now be initialized to a tabulated dependent variable based on the initialized independent variable space.
6) Pulled some weeds, including removing the noSolve function. This is the beginning of complete removal of the dummySolve. Still has a lot more weeds to go.
7) Changed some input files
** some tests ( methane_jet, heptane_pipe, coal_pipe) will fail and will need GS replacement because of the new heat loss calculation and the changes to the input files **
161 lines of code changed in 4 files:
RM'ing an old, unused property model.
Adding a filter to the scalar variance model.
Fixing a warning.
1 lines of code changed in 1 file:
1) Setting the density guess = true for table mixture fractions.
Note that this only applies to mixture fractions identified in the table header and
enthalpy. It doesn't apply for any other transported quantity that might require
density guess = true.
2) Adding a variable transformation for "inert mixing", wherein inert streams may be
mixed into the tabulated state-space ex post facto when using the LES constrained rate
model. This required a dynamic_cast which wasn't as elegant as I would have liked. May need to
review this later.
5 lines of code changed in 1 file:
Changing a bad naming convention for the turbulent viscosity.
2 lines of code changed in 1 file:
Intrusion boundary conditions for DQMOM.
6 lines of code changed in 2 files:
Better specification for this option. Input files updated accordingly.
1 lines of code changed in 1 file:
1) Update to documentation.
2) Added more flexibility for specifying the molecular diffusion coef.
for scalars
3) Turned on the option for using density_guess or actual density for
scalars.
Update 2) will change the answers.
470 lines of code changed in 4 files:
Fixing a few memory cleanup issues with DQMOM.
Cleaning up some recompiling of the task graph for MPMArches. This is
no longer needed without the dummy solve.
6 lines of code changed in 1 file:
Add missing rho in the molecular diffusivity term for scalars.
43 lines of code changed in 3 files:
Tony/Jeremy: Added a placeholder expression for density. This is
currently a hack.
Jeremy: Added molecular diffusivity for Arches scalar transport.
63 lines of code changed in 4 files:
Making the gaussian spec more intuitive.
3 lines of code changed in 1 file:
Bug fix in the cold flow model. Wasn't taking the inverse of the
MPMArches micro-density. This will affect the answers.
Also adding a gaussian initialization function for scalars.
40 lines of code changed in 2 files:
Reverting a portion of the last commit re: diffusion at Dirichlet
BCs and adding some clarifying comments.
Seems to make most sense to assume piecewise constant at boundaries
and live with it. Interpolating back from the bc_value and
interior nodes (last commit) doesn't make sense because it potentially violates
realizability for bounded scalars.
13 lines of code changed in 1 file:
Reverting earlier change on diffusion coefficient. Turns out that
density was being applied upstream in mu_t.
However, keeping the factor of "2" in Dirichlet boundary treatment which
seems to be mathematically correct.
Answers will still change but the acid_base problem shouldn't diverge.
21 lines of code changed in 2 files:
Rearrangement of diffusion term to be more consistent. Also changing
the way diffusion is handled at Dirichlet boundaries to be more
consistent with the the bc. Also added a few comments.
This will change stuff:
MPMARCHES-opt tests
:heptane_pipe:
:coal_table_pipe:
:intrusion_test:
74 lines of code changed in 3 files:
* added reference density location to periodic driven cavity problem
* Intrusions now store their user-defined name
* Added almgren initialization function for velocity.
* Changed the way mixture fraction and density are handled on inlets. Unlike Arches legacy code, the mixture fraction and the density are now consistent when using the new boundary conditions.
This change will cause these tests to fail:
:xplus_scalar_test: test failed comparison tests
:yplus_scalar_test: test failed comparison tests
:zplus_scalar_test: test failed comparison tests
:xminus_scalar_test: test failed comparison tests
:yminus_scalar_test: test failed comparison tests
:zminus_scalar_test: test failed comparison tests
37 lines of code changed in 1 file:
Fixed a bug with the laminar Pr model + a problem in referencing the
incorrect cell when actually using the model in Discretization_new.h.
Also, further refinement on the intrusion class. Seems to be working for
multiple patches now, even when geometry lines up with the patch
boundaries.
17 lines of code changed in 1 file:
Changing the map storage to use patchID.
Clean up of input interface.
Changing the way iterators are assined for the intrusion. They now
should be the face index of the intrusion rather than the first interior
index.
1 lines of code changed in 1 file:
Moved source term registration into source factory.
Created a builder for RMCRT radiation ---> give it a shot Todd.
6 lines of code changed in 2 files:
Turning back on <use_laminar_pr> for transport equations.
8 lines of code changed in 3 files:
Making source terms self-aware. ;) Now they can report back which source
type they actually represent.
5 lines of code changed in 2 files:
1) Fixed a bug where area varlabels not being destroyed.
2) Added sine initializiation.
3) Attempting to turn on vanleer limiter.
34 lines of code changed in 2 files:
Bug fix. The check for boundaries wasn't being performed correctly
causing problems at patch interfaces for the differencing scheme.
22 lines of code changed in 1 file:
Updating the input file/boundary condition interface. Boundary
conditions for velocity and transported scalars can now be set from
input files defining values at i,j,k locations on the boundary.
This update is causing very minor fuzz on local RT so GS's may need an
update.
6 lines of code changed in 1 file: