Lines of Code
[root]/CCA/Components/Arches/PropertyModels
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 59 (100.0%) | 1709 (100.0%) | 28.9 |
| jthornoc | 55 (93.2%) | 1644 (96.2%) | 29.8 |
| dav | 2 (3.4%) | 64 (3.7%) | 32.0 |
| harman | 2 (3.4%) | 1 (0.1%) | 0.5 |
Updates to the wall heat tranfer model framework, including putting it into
production mode.
Removing the <const_wall_temperature> spec from the new DORadiation
model. This was confusing and actually clashed with the
SolidWallTemperature spec in the <BoundaryConditions> section of the
input file. It is now on the user to specify BC's for the
SolidWallTemperature values if they want something other than the
resultant temperature from the indep. var space.
Updating some input files to be consistent with the new spec.
Local RT is reporting that methane_jet.ups will fail, but the
differences are in the noise.
1 lines of code changed in 2 files:
Initial commit for using radProps + RMCRT + Arches.
It's close to running.
1 lines of code changed in 2 files:
Deleting the boundary condition object.
0 lines of code changed in 2 files:
Now passing material id into new boundary condition interface rather
than the entire ArchesLabel set.
Applying BCs for heat loss.
12 lines of code changed in 3 files:
Fix a missing initialization call for the heat loss model.
2 lines of code changed in 1 file:
Cleaning up ABSKP model. Deleting the moment labels. Turning off property model for abskp for the coal_channel test. It appears that property models aren't being deleted correctly. Will look into this soon.
0 lines of code changed in 2 files:
Set _noisy_heat_loss to true... ???Is this correct - not sure what is going on with that line??? Fix spacing/indentation.
64 lines of code changed in 2 files:
The old mixture fraction solver spec is now optional. Leaving it out of
the inputfile will not solve the extra transport equation, but does
allocate some variables to keep other models working that were expecting
scalarSP. This should be removed at a later date.
1 lines of code changed in 1 file:
Created a common initialization method for all property models. This
fixed a bug in how property models were being initialized. This will
cause some answers to change due to the initial condition.
Also fixed a bug for transported variables that are initialized using a
table lookup. In this case, boundary conditions weren't being reapplied
which will also cause some answers to change.
Finally updated some input files to conform to new standard.
31 lines of code changed in 5 files:
** Big Changes **
1) Added more access function to BC data in BCUtil. This should help in determining if <value> is a double, string, or vector. I didn't see any previous method that provided this information.
2) ClassicTables now require explicit definitions of each independent variable, model, through either <TransportEqn> or <PropertyModel> definitions in the input file. (currently scalar variance is the one exception, where the old normalizedScalarVar can still be used).
3) Added a <PropertyModel> for heat_loss.
4) Transport equations can now have a "Tabulated" attribute spec for boundary conditions. The <value> should be specified as the string identifier for the dependent variable the user wants to use as the boundary condition. Note that this only works for Dirichlet conditions as Neumann conditions don't require a table lookup.
5) Transport equations can now be initialized to a tabulated dependent variable based on the initialized independent variable space.
6) Pulled some weeds, including removing the noSolve function. This is the beginning of complete removal of the dummySolve. Still has a lot more weeds to go.
7) Changed some input files
** some tests ( methane_jet, heptane_pipe, coal_pipe) will fail and will need GS replacement because of the new heat loss calculation and the changes to the input files **
374 lines of code changed in 4 files:
Rm'ing another unused property model.
Printing more information regarding the choice of turbulence model.
Somehow, CompDynamicProcedure didn't get all the PetscFilter ifdef's
cleaned up. This will change the answers as the previous RT results
which used this model essentially didn't have a turbulent viscosity.
0 lines of code changed in 3 files:
RM'ing an old, unused property model.
Adding a filter to the scalar variance model.
Fixing a warning.
8 lines of code changed in 4 files:
Deleting unused model.
0 lines of code changed in 3 files:
1) Trimming some dead wood. Unused files have been boxed and moved to the Attic/ for future reference.
2) Removing petsc completely from Filter.cc. This trimmed down the file considerably and removed the extra dangly bits among several files as a result.
3) Removing the #ifdef PetscFilter
4) Now allowing for no <Turbulence> spec -- defaults to "none".
5) All turbulence models now have a common problemSetup (problemSetupCommon) located in the base class definition.
6) Removed large sections of code in the turbulence models that dealt with #ifndef PetscFilter. It looks like the new filter, without petsc, should cover this scenario just fine.
7) Added scale-similarity scalar variance model. This isn't complete yet.
My local RT is messed up but I don't believe answers will change. Will review after the changes are submitted to ensure any changes are valid.
304 lines of code changed in 2 files:
Simplifying the filter interface a bit in preparation of getting rid of
the PETSC filter.
Adding a scale-similarity, scalar variance model.
3 lines of code changed in 3 files:
Actually add the files this time for the algebraic scalar dissipation
rate.
295 lines of code changed in 2 files:
Adding an algebraic expression for the scalar dissipation rate.
2 lines of code changed in 1 file:
1) Update to documentation.
2) Added more flexibility for specifying the molecular diffusion coef.
for scalars
3) Turned on the option for using density_guess or actual density for
scalars.
Update 2) will change the answers.
2 lines of code changed in 1 file:
Fixing a few memory cleanup issues with DQMOM.
Cleaning up some recompiling of the task graph for MPMArches. This is
no longer needed without the dummy solve.
3 lines of code changed in 1 file:
Updating the soot model to be consistent with the published version.
66 lines of code changed in 3 files:
Whoops. Accidently deleted a bunch of code in that last commit.
132 lines of code changed in 1 file:
Bug fix for soot model with more than one material.
Need to allocate scalars in dummy solve before the variance calculation
(which needs the scalar).
Curse you dummySolve!
8 lines of code changed in 1 file:
For the soot model: c3 -> c1 to be consistent with literature.
Added an input file using PETSC for the radiation solver.
4 lines of code changed in 2 files:
Keeping consistent with the old soot model, don't allow the model to
work until T > 1000K.
5 lines of code changed in 1 file:
A litle formatting change on the soot model.
Update the 4x4 methane case so that it uses the new soot model. Also
fixed several errors in the input file.
3 lines of code changed in 1 file:
Adding an empirical soot model that computes absorption coef for
radiation and soot volume fraction.
380 lines of code changed in 3 files:
Fixed a bug with the laminar Pr model + a problem in referencing the
incorrect cell when actually using the model in Discretization_new.h.
Also, further refinement on the intrusion class. Seems to be working for
multiple patches now, even when geometry lines up with the patch
boundaries.
7 lines of code changed in 2 files:
Turning back on <use_laminar_pr> for transport equations.
1 lines of code changed in 1 file: