Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 15 (100.0%) | 150 (100.0%) | 10.0 |
| jsutherland | 8 (53.3%) | 141 (94.0%) | 17.6 |
| dav | 3 (20.0%) | 7 (4.7%) | 2.3 |
| jas | 4 (26.7%) | 2 (1.3%) | 0.5 |
Update copyright year.
2 lines of code changed in 4 files:
Eliminate "using namespace std" and similar from header files. That is a big no-no!
3 lines of code changed in 2 files:
Explict use of namespace for vector.
0 lines of code changed in 2 files:
For const handles, return const pointers.
0 lines of code changed in 2 files:
The following (minor) updates are to fix issues or quite compiler
warnings when building under ICC on Ember@CHPC (thought they probably
apply to all ICC v12+ compilers.
M CCA/Components/Schedulers/MixedScheduler.h
M CCA/Components/Schedulers/MixedScheduler.cc
- Fix 'is virtual overloading intended' warning message. Signature of
child class function needs to match that of its parent.
M CCA/Components/Arches/CoalModels/ModelBase.h
- Cosmetics. White space is your friend.
M CCA/Components/Arches/CoalModels/HeatTransfer.h
M CCA/Components/Arches/CoalModels/SimpleHeatTransfer.h
M CCA/Components/Arches/TransportEqns/DQMOMEqnFactory.h
M CCA/Components/Arches/TransportEqns/EqnBase.h
M CCA/Components/Arches/TransportEqns/DQMOMEqn.h
M CCA/Components/Arches/LU.h
- Returning a 'const' non-pointer doesn't make sense... and causes ICC
to spew warnings all over the place.
M CCA/Components/Arches/DQMOM.cc
- Organize #includes alphabetically in order to understand what is
included more easily.
M CCA/Components/Arches/DQMOM.h
- Made weightedAbscissaModels into a vector of vectors of pointers.
ICC won't allow a vector of abstract classes... I'm actually not
quite sure how this variable is compiling or what it is used for, but
both ICC and GCC seem to be ok with the pointer version. It is possible
that this could cause an issue that I'm not immediately seeing, or cause
a memory leak. Perhaps someone familiar with this code could take a look?
M StandAlone/tools/pfs/sub.mk
M StandAlone/tools/puda/sub.mk
M StandAlone/tools/dumpfields/sub.mk
M StandAlone/tools/graphview/sub.mk
M StandAlone/tools/sub.mk
M StandAlone/Benchmarks/sub.mk
M testprograms/CubeRootTest/sub.mk
- These executables (at least when they use Ember's MPI) are required
to be linked against the thread library.
M Core/Containers/SuperBox.h
- There appears to be a 'hack' in our code that fixed an old problem with
ICC. However, it seems that icc 12.0.0 took care of the problem
and now our 'hack' doesn't compile. I've removed the hack and it
seems to be good now.
- Indentation... is your friend. (The comes under the whitespace category. ;)
7 lines of code changed in 1 file:
This checkin may break something if I was not able to build it. I will clean it up if that happens...
- removing "using" standard namespace stuff from headers. This is really bad practice, and anyone doing it should be flogged. Opening up a namespace in a header file defeats the purpose of namespaces because all downstream inclusions of the header file will also result in that namespace opening up. This can lead to inadvertent name clashes, etc. Only open a namespace in an implementation file!
- put the SymmMatrix3 implementation in the Uintah namespace to be consistent with its declaration.
138 lines of code changed in 4 files: